Disallow deleting jobs while an update is pending #19617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes the "Error" from the `{setV,v}alidationErrorMessage`
variables to pave the way for success feedback.
octavia-squidington-iv
added
area/platform
ambirdsall
changed the base branch from
alex/give-success-feedback-for-dbt-cloud-token-submission
to
alex/validate-dbt-cloud-service-tokens
josephkmh
approved these changes
Nov 18, 2022
|
In all cases, deletion is directly handled by the remove function from formik's FieldArrayHelper; I'm a little surprised by its behavior. Specifically, these behaviors are a head-scratching combination:
A glance at the FieldArray docs doesn't show a way to configure the behavior of |
ambirdsall
deleted the
alex/disallow-deleting-jobs-while-a-prior-submission-is-pending
branch
ambirdsall
added a commit
that referenced
this pull request
Nov 21, 2022
* Clean up type definitions
Also removes the "Error" from the `{setV,v}alidationErrorMessage`
variables to pave the way for success feedback.
* Show success message and clear form on successful dbt cloud token submission
* Always clear form error state and message in sync
* Disallow deleting jobs while an update is pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the Magically Reappearing Job bug shown in this Loom recording. If the user clicks the "X"/"remove job" button several times in quick succession, they can see jobs reappear when a prior delete's successful response resets the form to the remaining jobs (some of which were already removed from the DOM when a subsequent update was cued).