🪟 🔧 Show success message and clear form on successful dbt cloud token submisison #19611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
timroes
reviewed
Nov 18, 2022
airbyte-webapp/src/packages/cloud/views/settings/integrations/DbtCloudSettingsView.tsx
Show resolved
Hide resolved
ambirdsall
force-pushed
the
alex/validate-dbt-cloud-service-tokens
branch
from
6a5c8a5
to
b66a72d
Compare
Also removes the "Error" from the `{setV,v}alidationErrorMessage`
variables to pave the way for success feedback.
ambirdsall
force-pushed
the
alex/give-success-feedback-for-dbt-cloud-token-submission
branch
from
54a56f4
to
9f3bc05
Compare
|
I branched off of this new commit to make #19617; when that was merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote this quickly; I'm guessing that
components/ui/Toastwould be the conventional way to show the success message, rather than amessageprop on the input, is that correct?