Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 New implementation for AWS Secret Manager for issue #19690

Merged
merged 7 commits into from Dec 12, 2022
Merged

🎉 New implementation for AWS Secret Manager for issue #19690

merged 7 commits into from Dec 12, 2022

Commits on Dec 12, 2022

  1. 🎉 New implementation for AWS Secret Manager for issue 

    airbytehq#10518

Added new implementation AWSSecretManagerPersistence and integration tests AWSSecretManagerPersistenceIntegrationTest

A new implementation of SecretPersistence to support AWS Secret Manager AWSSecretManagerPersistence
New Integration tests as suggested on the open Issue, similar to GCP secret manager
    @mauricioalarcon @pmossman
    mauricioalarcon authored and pmossman committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    51c7140 View commit details
    Browse the repository at this point in the history

  2. Updated version to aws-secretsmanager-caching-java:1.0.2 

    - Added new argument check for AWS Secret Manager.
    @mauricioalarcon @pmossman
    mauricioalarcon authored and pmossman committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    7496aca View commit details
    Browse the repository at this point in the history

  3. exclude jackson-databind from aws dependency and run gradle format

    @pmossman
    pmossman committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    0516cdf View commit details
    Browse the repository at this point in the history

  4. bump aws-related dependencies to prevent old version of jackson-datab… 

    …ind from being pulled in
    @pmossman
    pmossman committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    f0510af View commit details
    Browse the repository at this point in the history

  5. - Added new entry for AWS_SECRET_MANAGER into SecretPersistence.java 

    - Externalized configurations for AWS Secret Manager into Configs and EnvConfigs.java as requested.
- Adjusted test to use new constructor for `AWSSecretManagerPersistence`
- Augmented instructions configuring-airbyte.md with the new config keys.
    @pmossman
    mauricioalarcon authored and pmossman committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    e742397 View commit details
    Browse the repository at this point in the history

  6. Formatting code.

    @pmossman
    mauricioalarcon authored and pmossman committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    1665a36 View commit details
    Browse the repository at this point in the history

  7. revert dependency version bump

    @pmossman
    pmossman committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    a24ca65 View commit details
    Browse the repository at this point in the history