Skip to content

Source Salesforce: make AccountHistory support BULK API - #19869

Merged
Denys Davydov (davydov-d) merged 3 commits into
masterfrom
ddavydov/#17503-source-salesforce-rm-AccountHistory-from-unsupported-bulk-streams
Nov 29, 2022
Merged

Source Salesforce: make AccountHistory support BULK API#19869
Denys Davydov (davydov-d) merged 3 commits into
masterfrom
ddavydov/#17503-source-salesforce-rm-AccountHistory-from-unsupported-bulk-streams

Conversation

@davydov-d

Copy link
Copy Markdown
Contributor

What

#17503
https://github.com/airbytehq/airbyte/pull/19286/files#r1030644846

How

Remove AccountHistory from unsupported BULK entities

@davydov-d Denys Davydov (davydov-d) linked an issue Nov 29, 2022 that may be closed by this pull request
@davydov-d

Denys Davydov (davydov-d) commented Nov 29, 2022

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/3572641399
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/3572641399
Python tests coverage:

Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/__init__.py            2      0   100%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/api.py               151     19    87%
source_salesforce/streams.py           311     75    76%
source_salesforce/rate_limiting.py      22      6    73%
source_salesforce/source.py             94     31    67%
source_salesforce/utils.py               8      7    12%
--------------------------------------------------------
TOTAL                                  596    139    77%
Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/utils.py               8      0   100%
source_salesforce/__init__.py            2      0   100%
source_salesforce/source.py             94      4    96%
source_salesforce/api.py               151     14    91%
source_salesforce/streams.py           311     38    88%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/rate_limiting.py      22      3    86%
--------------------------------------------------------
TOTAL                                  596     60    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1563    349    78%

Build Passed

Test summary info:

All Passed

@alafanechere Augustin (alafanechere) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feel free to publish and merge once the tests are passing.

@davydov-d

Denys Davydov (davydov-d) commented Nov 29, 2022

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-salesforce

🕑 Publishing the following connectors:
connectors/source-salesforce
https://github.com/airbytehq/airbyte/actions/runs/3572808074


Connector Did it publish? Were definitions generated?
connectors/source-salesforce

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d
Denys Davydov (davydov-d) merged commit 8ac5d50 into master Nov 29, 2022
@davydov-d
Denys Davydov (davydov-d) deleted the ddavydov/#17503-source-salesforce-rm-AccountHistory-from-unsupported-bulk-streams branch November 29, 2022 10:11
@octavia-squidington-iii
Octavia Squidington III (octavia-squidington-iii) temporarily deployed to more-secrets November 29, 2022 10:13 Inactive
@octavia-squidington-iii
Octavia Squidington III (octavia-squidington-iii) temporarily deployed to more-secrets November 29, 2022 10:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesforce

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Source Salesforce: "QUERY_TIMEOUT"

5 participants