Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Tutorial config-based invalid keywords #20071 #20078

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Fix: Tutorial config-based invalid keywords #20071 #20078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57fc9d1
Update 5-incremental-reads.md in response of Issue #20047
juweins Dec 5, 2022
0f35da5
Updated 5-incremental-reads.md #2
juweins Dec 5, 2022
7265962
Fix: Low Code Connector tutorial yaml #20071
juweins Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
* [jonathan-duval](https://github.com/jonathan-duval)
* [jonstacks](https://github.com/jonstacks)
* [jrhizor](https://github.com/jrhizor)
* [juweins](https://github.com/juweins)
* [keu](https://github.com/keu)
* [lazebnyi](https://github.com/lazebnyi)
* [lizdeika](https://github.com/lizdeika)
Expand Down
8 changes: 4 additions & 4 deletions docs/connector-development/config-based/tutorial/3-connecting-to-the-API-source.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ Let's populate the specification (`spec`) and the configuration (`secrets/config

```yaml
spec:
documentationUrl: https://docs.airbyte.io/integrations/sources/exchangeratesapi
connectionSpecification:
documentation_url: https://docs.airbyte.io/integrations/sources/exchangeratesapi
connection_specification:
$schema: http://json-schema.org/draft-07/schema#
title: exchangeratesapi.io Source Spec
type: object
Expand Down Expand Up @@ -170,8 +170,8 @@ check:
stream_names:
- "rates"
spec:
documentationUrl: https://docs.airbyte.io/integrations/sources/exchangeratesapi
connectionSpecification:
documentation_url: https://docs.airbyte.io/integrations/sources/exchangeratesapi
connection_specification:
$schema: http://json-schema.org/draft-07/schema#
title: exchangeratesapi.io Source Spec
type: object
Expand Down
12 changes: 6 additions & 6 deletions docs/connector-development/config-based/tutorial/5-incremental-reads.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ First we'll update the spec block in `source_exchange_rates_tutorial/exchange_ra

```yaml
spec:
documentationUrl: https://docs.airbyte.io/integrations/sources/exchangeratesapi
connectionSpecification:
documentation_url: https://docs.airbyte.io/integrations/sources/exchangeratesapi
connection_specification:
Comment on lines +14 to +15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you changing this? It doesn't look correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came accross this error by validating issue #20047 . Strictly following the tutorial example, both keywords in the yaml snippets seem to be incorrect. Changing them to the proposed naming resolves the error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is issue has been stated in #18663

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed one update from low-code CDK https://github.com/airbytehq/airbyte/pull/18411/files#r1003903362

$schema: http://json-schema.org/draft-07/schema#
title: exchangeratesapi.io Source Spec
type: object
Expand Down Expand Up @@ -103,7 +103,7 @@ definitions:
datetime_format: "%Y-%m-%d"
end_datetime:
datetime: "{{ now_utc() }}"
datetime_format: "%Y-%m-%d %H:%M:%S.%f"
datetime_format: "%Y-%m-%d %H:%M:%S.%f+00:00"
step: "1d"
datetime_format: "%Y-%m-%d"
cursor_field: "{{ options['stream_cursor_field'] }}"
Expand Down Expand Up @@ -181,7 +181,7 @@ definitions:
datetime_format: "%Y-%m-%d"
end_datetime:
datetime: "{{ now_utc() }}"
datetime_format: "%Y-%m-%d %H:%M:%S.%f"
datetime_format: "%Y-%m-%d %H:%M:%S.%f+00:00"
step: "1d"
datetime_format: "%Y-%m-%d"
cursor_field: "{{ options['stream_cursor_field'] }}"
Expand Down Expand Up @@ -210,8 +210,8 @@ check:
stream_names:
- "rates"
spec:
documentationUrl: https://docs.airbyte.io/integrations/sources/exchangeratesapi
connectionSpecification:
documentation_url: https://docs.airbyte.io/integrations/sources/exchangeratesapi
connection_specification:
$schema: http://json-schema.org/draft-07/schema#
title: exchangeratesapi.io Source Spec
type: object
Expand Down