update docs for google-ads and facebook-marketing to warn about updating dynamic streams from custom insights #20174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing dynamic streams from custom insights
octavia-squidington-iv
added
the
area/documentation
girarda
approved these changes
Dec 9, 2022
brianjlai
deleted the
brian/update_google_and_facebook_custom_streams_docs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We've noticed a small uptick in oncall issues where customers are modifying source configuration fields that are used to generate certain streams in the case of
facebook-marketingandgoogle-ads. We should be alerting them so they are aware that their updates or removal of setting will require them to update connections from these sources.https://github.com/airbytehq/oncall/issues/1137
https://github.com/airbytehq/oncall/issues/1156
How
Longer term, auto schema detection should be able to identify when configs change the available streams, but in the immediate this is a simple way to highlight how certain configs will affect the set of available streams.