🪟 🔧 Allow overwriting features in dev by env variables #20231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundito
reviewed
Dec 8, 2022
timroes
commented
Dec 8, 2022
| }); | ||
|
|
||
| afterEach(() => { | ||
| (process.env.NODE_ENV as string) = "test"; |
There was a problem hiding this comment.
ℹ️ Need to cast this, since this is by default readonly so we can't overwrite it.
krishnaglick
reviewed
Dec 8, 2022
Co-authored-by: Krishna (kc) Glick <krishna@airbyte.io>
edmundito
approved these changes
Dec 9, 2022
| }); | ||
|
|
||
| it("should not overwrite in a non dev environment", () => { | ||
| (process.env.NODE_ENV as string) = "productions"; |
There was a problem hiding this comment.
Nit: It's probably production without the s, but it works for the test.
krishnaglick
requested review from
krishnaglick
and removed request for
krishnaglick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allows any
FeatureItemto be overwritten in development by a env variable with the nameREACT_APP_FEATURE_{ID}, e.g. one can have the following in the.env.developmentfile:To disable syncs and allow geography changes.
This is only enabled during development, since this isn't meant to be misused accidentally in environments instead of the regular feature chain (default features, workspace, users).