🪟 🔧 Allow overwriting experiments and features during development #20843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
josephkmh
reviewed
Jan 2, 2023
timroes
commented
Jan 12, 2023
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
|
|
||
| *.iml | ||
| /.idea | ||
|
|
||
| .npmrc |
There was a problem hiding this comment.
ℹ️ Not sure why this was ignored, since it was also checked in (and should be). So I removed it from the .gitignore file.
timroes
changed the title
josephkmh
approved these changes
Jan 17, 2023
| const EXPERIMENTS_FILE = path.resolve(__dirname, "../.experiments.json"); | ||
|
|
||
| if (fs.existsSync(EXPERIMENTS_FILE)) { | ||
| console.log("\nOverwriting experiments from .experiments.json ..."); |
There was a problem hiding this comment.
Just a note: these console.log calls get cleared by CRA in the console very quickly, so not super useful. With vite we could disable the clearScreen option to keep this debug info in the console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This allows easily overwriting the state of experiments or features during development with a custom value. Those overwrites work whether the app is run in OSS or in Cloud mode.
Those overwrite files are ignored in git so they can't accidentally be commited. Also the overwrites will only work during development, so they can't be missued in production systems.
Documentation about that feature will be added to Notion after merging.
Experiments
You can overwrite the state of experiments (
useExperiment) via a file called.experiments.jsonin theairbyte-webappfolder, by their experiment id:{ "authPage.signup.hideName": true, "connector.orderOverwrite": { "connectorId": 5 } }