Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAT: skip backward compatibility tests on spec/catalog if previous and actual spec/catalog are identical #20435

Merged
merged 5 commits into from
Dec 14, 2022
Merged

SAT: skip backward compatibility tests on spec/catalog if previous and actual spec/catalog are identical #20435

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f9b63da
skip backward compatibility tests if spec are identical
alafanechere Dec 13, 2022
2424420
bump version
alafanechere Dec 13, 2022
200b009
skip for discover too
alafanechere Dec 13, 2022
bf65ce5
update changelog
alafanechere Dec 13, 2022
ac196a6
format
alafanechere Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions airbyte-integrations/bases/source-acceptance-test/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 0.2.23
Skip backward compatibility tests on specifications if actual and previous spec are identical.

## 0.2.22
Capture control messages to store and use updated configurations. [#19979](https://github.com/airbytehq/airbyte/pull/19979).

Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/bases/source-acceptance-test/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ COPY pytest.ini setup.py ./
COPY source_acceptance_test ./source_acceptance_test
RUN pip install .

LABEL io.airbyte.version=0.2.22
LABEL io.airbyte.version=0.2.23
LABEL io.airbyte.name=airbyte/source-acceptance-test

ENTRYPOINT ["python", "-m", "pytest", "-p", "source_acceptance_test.plugin", "-r", "fEsx"]
5 changes: 4 additions & 1 deletion airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,10 @@ class TestSpec(BaseTest):
previous_spec_cache: ConnectorSpecification = None

@pytest.fixture(name="skip_backward_compatibility_tests")
def skip_backward_compatibility_tests_fixture(self, inputs: SpecTestConfig, previous_connector_docker_runner: ConnectorRunner) -> bool:
def skip_backward_compatibility_tests_fixture(self, inputs: SpecTestConfig, previous_connector_docker_runner: ConnectorRunner, previous_connector_spec: ConnectorSpecification, actual_connector_spec: ConnectorSpecification) -> bool:
if actual_connector_spec == previous_connector_spec:
pytest.skip("The previous and actual specifications are identical.")
erohmensing marked this conversation as resolved.
Show resolved Hide resolved

if previous_connector_docker_runner is None:
pytest.skip("The previous connector image could not be retrieved.")

Expand Down