Fix OSS integration tests for docs (#3663) #20590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ In "Docs PR check mode" stop before "yarn deploy"
tkorenko
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
supertopher
approved these changes
Dec 16, 2022
supertopher
reviewed
Dec 16, 2022
| @@ -79,6 +79,12 @@ if ! yarn build; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| # "check PR mode" -- we run "yarn build" and stop before "yarn deploy" | |||
| if [ "${SKIP_DEPLOY}" = "yes" ]; then | |||
There was a problem hiding this comment.
SKIP_DEPLOY doesn't exist for local runs
There was a problem hiding this comment.
which is perfectly fine for local deploys
There was a problem hiding this comment.
we get then if [ "" = "yes" ]; then ... fi -- this code block is skipped for local runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What