Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OSS integration tests for docs (#3663) #20590

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Fix OSS integration tests for docs (#3663) #20590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tools/bin/deploy_docusaurus
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,12 @@ if ! yarn build; then
exit 1
fi

# "check PR mode" -- we run "yarn build" and stop before "yarn deploy"
if [ "${SKIP_DEPLOY}" = "yes" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SKIP_DEPLOY doesn't exist for local runs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which is perfectly fine for local deploys

Copy link
Contributor Author

@tkorenko tkorenko Dec 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we get then if [ "" = "yes" ]; then ... fi -- this code block is skipped for local runs

echo -e "$blue_text""Check mode is ON: skipipping yarn deploy && git push CNAME to repo!\n\n""$default_text"
exit 0
fi

# Check tty for local/remote deploys (we expect cloud to be non-interactive)
# results like /dev/ttys000 || not a tty
if test "$(tty)" == "not a tty"; then
Expand All @@ -95,8 +101,6 @@ if test "$(tty)" == "not a tty"; then
else
yarn run deploy
fi
YARN_DEPLOY_EXIT_STATUS=$?


# Git makes more sense from /
cd ..
Expand Down