Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigquery-denormalized fix integration tests #20640

Merged
merged 2 commits into from
Dec 27, 2022
Merged

Bigquery-denormalized fix integration tests #20640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6863d00
Bigquery-denormalized update spec plus destination_definitions.yaml t…
suhomud Dec 19, 2022
7b6c93e
Merge branch 'master' into suhomud/fix_bigquery_denormalized_spec_nor…
suhomud Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions airbyte-config/init/src/main/resources/seed/destination_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@
dockerImageTag: 1.2.9
documentationUrl: https://docs.airbyte.com/integrations/destinations/bigquery
icon: bigquery.svg
normalizationConfig:
normalizationRepository: airbyte/normalization
normalizationTag: 0.2.25
normalizationIntegrationType: bigquery
Comment on lines -63 to -66
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm: are we saying here that this destination does not support normalization? (from the name -denormalized i would assume so, but confirming 😄 )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was marked in spec.json

resourceRequirements:
jobSpecific:
- jobType: sync
Expand Down
2 changes: 1 addition & 1 deletion ...te-integrations/connectors/destination-bigquery-denormalized/src/main/resources/spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"documentationUrl": "https://docs.airbyte.com/integrations/destinations/bigquery",
"supportsIncremental": true,
"supportsNormalization": false,
"supportsDBT": true,
"supportsDBT": false,
"supported_destination_sync_modes": ["overwrite", "append"],
"connectionSpecification": {
"$schema": "http://json-schema.org/draft-07/schema#",
Expand Down
5 changes: 0 additions & 5 deletions ...byte/integrations/destination/bigquery/BigQueryDenormalizedDestinationAcceptanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,6 @@ protected JsonNode getFailCheckConfig() {
return config;
}

@Override
protected boolean supportsDBT() {
return true;
}

@Override
protected boolean implementsNamespaces() {
return true;
Expand Down