Connector acceptance test: Fix discovered catalog caching for different configs #22301

grubberr · 2023-02-02T08:45:59Z

What

for different configs keep different cached values of discovered catalog
always reset cache dict if cache_discovered_catalog=True (in previous implementation we overwrite on top of old cache - which is not good)

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions · 2023-02-02T08:49:20Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector or module version
Add changelog
Publish the new version

✅ Sources (63)

Connector	Version	Changelog	Publish
`source-airtable`	`2.0.3`	✅	✅
`source-amazon-ads`	`0.1.29`	✅	✅
`source-amazon-seller-partner`	`0.2.31`	✅	✅
`source-amazon-sqs`	`0.1.0`	✅	✅
`source-amplitude`	`0.1.21`	✅	✅
`source-appsflyer`	`0.1.0`	✅	✅
`source-asana`	`0.1.5`	✅	✅
`source-azure-table`	`0.1.3`	✅	✅
`source-braintree`	`0.1.3`	✅	✅
`source-cart`	`0.2.0`	✅	✅
`source-chargebee`	`0.1.16`	✅	✅
`source-commercetools`	`0.1.0`	✅	✅
`source-confluence`	`0.1.1`	✅	✅
`source-datadog`	`0.1.0`	✅	✅
`source-delighted`	`0.2.0`	✅	✅
`source-drift`	`0.2.5`	✅	✅
`source-facebook-marketing`	`0.2.84`	✅	✅
`source-freshcaller`	`0.1.0`	✅	✅
`source-freshsales`	`0.1.2`	✅	✅
`source-freshservice`	`0.1.1`	✅	✅
`source-github`	`0.4.1`	✅	✅
`source-gitlab`	`1.0.2`	✅	✅
`source-google-ads`	`0.2.9`	✅	✅
`source-google-search-console`	`0.1.19`	✅	✅
`source-greenhouse`	`0.3.0`	✅	✅
`source-harvest`	`0.1.15`	✅	✅
`source-instagram`	`1.0.1`	✅	✅
`source-iterable`	`0.1.23`	✅	✅
`source-klaviyo`	`0.1.12`	✅	✅
`source-lemlist`	`0.1.1`	✅	✅
`source-lever-hiring`	`0.1.3`	✅	✅
`source-linnworks`	`0.1.5`	✅	✅
`source-mailchimp`	`0.3.3`	✅	✅
`source-mailgun`	`0.1.0`	✅	✅
`source-monday`	`0.2.2`	✅	✅
`source-notion`	`1.0.1`	✅	✅
`source-okta`	`0.1.14`	✅	✅
`source-onesignal`	`0.1.2`	✅	✅
`source-openweather`	`0.1.6`	✅	✅
`source-outreach`	`0.1.2`	✅	✅
`source-pardot`	`0.1.1`	✅	✅
`source-paystack`	`0.1.1`	✅	✅
`source-pinterest`	`0.2.2`	✅	✅
`source-pipedrive`	`0.1.13`	✅	✅
`source-plaid`	`0.3.2`	✅	✅
`source-posthog`	`0.1.8`	✅	✅
`source-prestashop`	`0.3.0`	✅	✅
`source-quickbooks-singer`	`0.1.5`	✅	✅
`source-recharge`	`0.2.5`	✅	✅
`source-retently`	`0.1.3`	✅	✅
`source-salesforce`	`1.0.30`	✅	✅
`source-salesloft`	`0.1.3`	✅	✅
`source-sendgrid`	`0.3.1`	✅	✅
`source-sentry`	`0.1.11`	✅	✅
`source-strava`	`0.1.2`	✅	✅
`source-surveymonkey`	`0.1.14`	✅	✅
`source-tplcentral`	`0.1.1`	✅	✅
`source-twilio`	`0.1.15`	✅	✅
`source-weatherstack`	`0.1.0`	✅	✅
`source-youtube-analytics`	`0.1.3`	✅	✅
`source-zendesk-sunshine`	`0.1.1`	✅	✅
`source-zendesk-talk`	`0.1.6`	✅	✅
`source-zenloop`	`0.1.4`	✅	✅

See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-02-02T08:52:23Z

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/4072776658
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/4072776658
No Python unittests run

Build Passed

Test summary info:

All Passed

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-02-02T11:59:34Z

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/4074222185
❌ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/4074222185
🐛

Build Failed

Test summary info:

Could not find result summary

grubberr · 2023-02-02T16:49:06Z

/test connector=bases/connector-acceptance-test

🕑 bases/connector-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/4076708138
✅ bases/connector-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/4076708138
No Python unittests run

Build Passed

Test summary info:

All Passed

evantahler · 2023-02-03T17:26:25Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4086438685
❌ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4086438685
🐛 https://gradle.com/s/h46qpfr6fzmd6

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs1]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs1]
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:22: `future_state` has a bypass reason, skipping.
============= 2 failed, 64 passed, 6 skipped in 101.77s (0:01:41) ==============

evantahler · 2023-02-03T17:26:31Z

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/4086439488
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/4086439488
Python tests coverage:

Name                             Stmts   Miss  Cover
----------------------------------------------------
source_github/utils.py              14      0   100%
source_github/github_schema.py    8807      0   100%
source_github/__init__.py            2      0   100%
source_github/streams.py           855     91    89%
source_github/graphql.py           167     22    87%
source_github/source.py            106     25    76%
----------------------------------------------------
TOTAL                             9951    138    99%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     217    101    53%   37, 43-45, 50, 55, 78, 84, 90-92, 111, 116-118, 124-126, 132-133, 138-139, 144, 150, 159-168, 174-179, 194, 218, 249, 255, 263-271, 279-292, 300-313, 318-324, 331-342, 349-365
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1696    347    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 44 passed, 3 skipped in 331.64s (0:05:31) ===================

evantahler

👍 pending the connector tests above ^

grubberr · 2023-02-06T16:09:59Z

/test connector=bases/connector-acceptance-test

🕑 bases/connector-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/4105569383
✅ bases/connector-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/4105569383
No Python unittests run

Build Passed

Test summary info:

All Passed

grubberr · 2023-02-06T16:28:24Z

/publish connector=bases/connector-acceptance-test auto-bump-version=false

🕑 Publishing the following connectors:
bases/connector-acceptance-test
https://github.com/airbytehq/airbyte/actions/runs/4105737929

Connector	Did it publish?	Were definitions generated?
bases/connector-acceptance-test	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* master: Discover worker starts to use API to write schema result (#21875) 🪟 🎉 Connector Builder Landing Page (#22122) Fix pnpm cache path (#22418) Add additional shorter setup guides (#22318) Source Amazon Ads: fix reports stream records primary keys (#21677) Connector acceptance test: Fix discovered catalog caching for different configs (#22301) 🪟🐛 Make modal scrollable (#21973) only compute diff if the schema discovery actually succeeded (#22377) Source Klaviyo: fix schema (#22071) 🪟 🔧 Switch to `pnpm` for package managing (#22053) Source Sentry: turn on default availability strategy (#22303) Source freshdesk: deduplicate table names (#22164)

* master: (86 commits) Discover worker starts to use API to write schema result (#21875) 🪟 🎉 Connector Builder Landing Page (#22122) Fix pnpm cache path (#22418) Add additional shorter setup guides (#22318) Source Amazon Ads: fix reports stream records primary keys (#21677) Connector acceptance test: Fix discovered catalog caching for different configs (#22301) 🪟🐛 Make modal scrollable (#21973) only compute diff if the schema discovery actually succeeded (#22377) Source Klaviyo: fix schema (#22071) 🪟 🔧 Switch to `pnpm` for package managing (#22053) Source Sentry: turn on default availability strategy (#22303) Source freshdesk: deduplicate table names (#22164) Update connector-acceptance-tests-reference.md (#22370) Update the default security groups for the EC2 runner (#22347) Trace refresh schema operations (#22326) Remove manual docker upgrades from workflows (#22344) Update CODEOWNERS for connector acceptance tests to connector ops (#22341) 🐛 source: airtable - handle singleSelect types (#22311) Source tiktok: chunk advertiser IDs (#22309) 🪟 🧪 E2E Tests for auto-detect schema changes (#20682) ...

* master: (24 commits) Discover worker starts to use API to write schema result (#21875) 🪟 🎉 Connector Builder Landing Page (#22122) Fix pnpm cache path (#22418) Add additional shorter setup guides (#22318) Source Amazon Ads: fix reports stream records primary keys (#21677) Connector acceptance test: Fix discovered catalog caching for different configs (#22301) 🪟🐛 Make modal scrollable (#21973) only compute diff if the schema discovery actually succeeded (#22377) Source Klaviyo: fix schema (#22071) 🪟 🔧 Switch to `pnpm` for package managing (#22053) Source Sentry: turn on default availability strategy (#22303) Source freshdesk: deduplicate table names (#22164) Update connector-acceptance-tests-reference.md (#22370) Update the default security groups for the EC2 runner (#22347) Trace refresh schema operations (#22326) Remove manual docker upgrades from workflows (#22344) Update CODEOWNERS for connector acceptance tests to connector ops (#22341) 🐛 source: airtable - handle singleSelect types (#22311) Source tiktok: chunk advertiser IDs (#22309) 🪟 🧪 E2E Tests for auto-detect schema changes (#20682) ...

grubberr added 4 commits February 1, 2023 22:31

expected_records.jsonl and expected_records2.jsonl added

a0d713d

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Merge branch 'master' into grubberr/19068-source-tiktok-marketing

53ace3a

test_strictness_level: "high" - added

94752c9

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Fix discovered catalog caching.

4d97b4c

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

octavia-squidington-iii added area/connectors Connector related issues connectors/source/tiktok-marketing labels Feb 2, 2023

grubberr changed the title ~~SAT: Fix discovered catalog caching~~ SAT: Fix discovered catalog caching for different configs Feb 2, 2023

CHANGELOG.md updated

af9dce0

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr added 2 commits February 2, 2023 08:50

acceptance-test-config.yml - revert to master

ec1b0c2

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

expected_records.jsonl, expected_records2.jsonl - removed

81e52e7

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

octavia-squidington-iii removed the area/connectors Connector related issues label Feb 2, 2023

grubberr self-assigned this Feb 2, 2023

grubberr requested a review from alafanechere February 2, 2023 09:04

grubberr mentioned this pull request Feb 2, 2023

Source TikTok Marketing: enabled high test strictness level in SAT #22244

Merged

14 tasks

Merge branch 'master' into grubberr/sat-fix-cache-discovered-catalog

0ee04cf

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr requested a review from brianjlai February 2, 2023 16:48

lazebnyi requested review from maxi297 and girarda February 2, 2023 22:46

YowanR requested a review from evantahler February 3, 2023 17:19

evantahler approved these changes Feb 3, 2023

View reviewed changes

grubberr changed the title ~~SAT: Fix discovered catalog caching for different configs~~ Connector acceptance test: Fix discovered catalog caching for different configs Feb 6, 2023

Merge branch 'master' into grubberr/sat-fix-cache-discovered-catalog

b16a217

grubberr merged commit 449c3d8 into master Feb 6, 2023

grubberr deleted the grubberr/sat-fix-cache-discovered-catalog branch February 6, 2023 16:49

github-actions bot mentioned this pull request Feb 7, 2023

Bump helm chart version reference to 0.43.28 #22489

Closed

This was referenced Feb 8, 2023

Bump Airbyte version from 0.40.32 to 0.40.33 #22578

Closed

Bump Airbyte version from 0.40.32 to 0.40.33 #22689

Closed

Bump Airbyte version from 0.40.32 to 0.40.33 #22839

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Connector acceptance test: Fix discovered catalog caching for different configs #22301

Connector acceptance test: Fix discovered catalog caching for different configs #22301

grubberr commented Feb 2, 2023 •

edited

Loading

github-actions bot commented Feb 2, 2023 •

edited

Loading

✅ Sources (63)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

grubberr commented Feb 2, 2023 •

edited by github-actions bot

Loading

grubberr commented Feb 2, 2023 •

edited by github-actions bot

Loading

grubberr commented Feb 2, 2023 •

edited by github-actions bot

Loading

evantahler commented Feb 3, 2023 •

edited by github-actions bot

Loading

evantahler commented Feb 3, 2023 •

edited by github-actions bot

Loading

evantahler left a comment

grubberr commented Feb 6, 2023 •

edited by github-actions bot

Loading

grubberr commented Feb 6, 2023 •

edited by github-actions bot

Loading

Connector acceptance test: Fix discovered catalog caching for different configs #22301

Connector acceptance test: Fix discovered catalog caching for different configs #22301

Conversation

grubberr commented Feb 2, 2023 • edited Loading

What

github-actions bot commented Feb 2, 2023 • edited Loading

Affected Connector Report

✅ Sources (63)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

grubberr commented Feb 2, 2023 • edited by github-actions bot Loading

Build Passed

grubberr commented Feb 2, 2023 • edited by github-actions bot Loading

Build Failed

grubberr commented Feb 2, 2023 • edited by github-actions bot Loading

Build Passed

evantahler commented Feb 3, 2023 • edited by github-actions bot Loading

Build Failed

evantahler commented Feb 3, 2023 • edited by github-actions bot Loading

Build Passed

evantahler left a comment

Choose a reason for hiding this comment

grubberr commented Feb 6, 2023 • edited by github-actions bot Loading

Build Passed

grubberr commented Feb 6, 2023 • edited by github-actions bot Loading

grubberr commented Feb 2, 2023 •

edited

Loading

github-actions bot commented Feb 2, 2023 •

edited

Loading

grubberr commented Feb 2, 2023 •

edited by github-actions bot

Loading

grubberr commented Feb 2, 2023 •

edited by github-actions bot

Loading

grubberr commented Feb 2, 2023 •

edited by github-actions bot

Loading

evantahler commented Feb 3, 2023 •

edited by github-actions bot

Loading

evantahler commented Feb 3, 2023 •

edited by github-actions bot

Loading

grubberr commented Feb 6, 2023 •

edited by github-actions bot

Loading

grubberr commented Feb 6, 2023 •

edited by github-actions bot

Loading