Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Sentry: turn on default availability strategy #22303

Merged
merged 8 commits into from
Feb 6, 2023

Conversation

davydov-d
Copy link
Collaborator

What

https://github.com/airbytehq/oncall/issues/1383

How

Use default availability strategy not to fail syncs when 403 error is risen

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/sentry labels Feb 2, 2023
@davydov-d
Copy link
Collaborator Author

davydov-d commented Feb 2, 2023

/test connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/4073203145
✅ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/4073203145
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_sentry/source.py        18      0   100%
source_sentry/__init__.py       2      0   100%
source_sentry/streams.py       93     14    85%
-----------------------------------------------
TOTAL                         113     14    88%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
======================== 36 passed, 2 skipped in 59.43s ========================

@davydov-d
Copy link
Collaborator Author

davydov-d commented Feb 2, 2023

/publish connector=connectors/source-sentry

🕑 Publishing the following connectors:
connectors/source-sentry
https://github.com/airbytehq/airbyte/actions/runs/4073714861


Connector Did it publish? Were definitions generated?
connectors/source-sentry

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d
Copy link
Collaborator Author

davydov-d commented Feb 2, 2023

/test connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/4073778235
✅ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/4073778235
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_sentry/source.py        18      0   100%
source_sentry/__init__.py       2      0   100%
source_sentry/streams.py       93     14    85%
-----------------------------------------------
TOTAL                         113     14    88%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
=================== 36 passed, 2 skipped in 67.06s (0:01:07) ===================

@davydov-d
Copy link
Collaborator Author

davydov-d commented Feb 2, 2023

/publish connector=connectors/source-sentry

🕑 Publishing the following connectors:
connectors/source-sentry
https://github.com/airbytehq/airbyte/actions/runs/4074055927


Connector Did it publish? Were definitions generated?
connectors/source-sentry

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@airbyteio airbyteio temporarily deployed to more-secrets February 2, 2023 11:59 — with GitHub Actions Inactive
@airbyteio airbyteio temporarily deployed to more-secrets February 2, 2023 11:59 — with GitHub Actions Inactive
@airbyteio airbyteio temporarily deployed to more-secrets February 2, 2023 12:34 — with GitHub Actions Inactive
@airbyteio airbyteio temporarily deployed to more-secrets February 2, 2023 12:34 — with GitHub Actions Inactive
@davydov-d davydov-d temporarily deployed to more-secrets February 2, 2023 14:50 — with GitHub Actions Inactive
@davydov-d davydov-d temporarily deployed to more-secrets February 2, 2023 14:50 — with GitHub Actions Inactive
@davydov-d davydov-d temporarily deployed to more-secrets February 2, 2023 15:41 — with GitHub Actions Inactive
@davydov-d davydov-d temporarily deployed to more-secrets February 2, 2023 15:41 — with GitHub Actions Inactive
@davydov-d davydov-d temporarily deployed to more-secrets February 2, 2023 15:53 — with GitHub Actions Inactive
@davydov-d davydov-d temporarily deployed to more-secrets February 2, 2023 15:53 — with GitHub Actions Inactive
@davydov-d davydov-d temporarily deployed to more-secrets February 3, 2023 07:24 — with GitHub Actions Inactive
@davydov-d davydov-d temporarily deployed to more-secrets February 3, 2023 07:24 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.52%

@davydov-d davydov-d merged commit 7326731 into master Feb 6, 2023
@davydov-d davydov-d deleted the ddavydov/#1383-source-sentry-handle-403-error branch February 6, 2023 15:22
letiescanciano added a commit that referenced this pull request Feb 6, 2023
* master:
  Discover worker starts to use API to write schema result (#21875)
  🪟 🎉  Connector Builder Landing Page (#22122)
  Fix pnpm cache path (#22418)
  Add additional shorter setup guides (#22318)
  Source Amazon Ads: fix reports stream records primary keys (#21677)
  Connector acceptance test: Fix discovered catalog caching for different configs (#22301)
  🪟🐛 Make modal scrollable (#21973)
  only compute diff if the schema discovery actually succeeded (#22377)
  Source Klaviyo: fix schema (#22071)
  🪟 🔧 Switch to `pnpm` for package managing (#22053)
  Source Sentry: turn on default availability strategy (#22303)
  Source freshdesk: deduplicate table names (#22164)
letiescanciano added a commit that referenced this pull request Feb 6, 2023
* master: (86 commits)
  Discover worker starts to use API to write schema result (#21875)
  🪟 🎉  Connector Builder Landing Page (#22122)
  Fix pnpm cache path (#22418)
  Add additional shorter setup guides (#22318)
  Source Amazon Ads: fix reports stream records primary keys (#21677)
  Connector acceptance test: Fix discovered catalog caching for different configs (#22301)
  🪟🐛 Make modal scrollable (#21973)
  only compute diff if the schema discovery actually succeeded (#22377)
  Source Klaviyo: fix schema (#22071)
  🪟 🔧 Switch to `pnpm` for package managing (#22053)
  Source Sentry: turn on default availability strategy (#22303)
  Source freshdesk: deduplicate table names (#22164)
  Update connector-acceptance-tests-reference.md (#22370)
  Update the default security groups for the EC2 runner (#22347)
  Trace refresh schema operations (#22326)
  Remove manual docker upgrades from workflows (#22344)
  Update CODEOWNERS for connector acceptance tests to connector ops (#22341)
  🐛 source: airtable - handle singleSelect types (#22311)
  Source tiktok: chunk advertiser IDs (#22309)
  🪟 🧪 E2E Tests for auto-detect schema changes (#20682)
  ...
letiescanciano added a commit that referenced this pull request Feb 6, 2023
* master: (24 commits)
  Discover worker starts to use API to write schema result (#21875)
  🪟 🎉  Connector Builder Landing Page (#22122)
  Fix pnpm cache path (#22418)
  Add additional shorter setup guides (#22318)
  Source Amazon Ads: fix reports stream records primary keys (#21677)
  Connector acceptance test: Fix discovered catalog caching for different configs (#22301)
  🪟🐛 Make modal scrollable (#21973)
  only compute diff if the schema discovery actually succeeded (#22377)
  Source Klaviyo: fix schema (#22071)
  🪟 🔧 Switch to `pnpm` for package managing (#22053)
  Source Sentry: turn on default availability strategy (#22303)
  Source freshdesk: deduplicate table names (#22164)
  Update connector-acceptance-tests-reference.md (#22370)
  Update the default security groups for the EC2 runner (#22347)
  Trace refresh schema operations (#22326)
  Remove manual docker upgrades from workflows (#22344)
  Update CODEOWNERS for connector acceptance tests to connector ops (#22341)
  🐛 source: airtable - handle singleSelect types (#22311)
  Source tiktok: chunk advertiser IDs (#22309)
  🪟 🧪 E2E Tests for auto-detect schema changes (#20682)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/sentry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants