Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Zendesk Support: add availability strategy #22308

Conversation

roman-yermilov-gl
Copy link
Contributor

@roman-yermilov-gl roman-yermilov-gl commented Feb 2, 2023

What

Add availability strategy. Fix tests: fix expected records, add missing streams to configured catalog, handle error for tickets stream when state is abnormal

@roman-yermilov-gl roman-yermilov-gl self-assigned this Feb 2, 2023
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 2, 2023 14:52 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 2, 2023 14:52 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 2, 2023 14:58 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 2, 2023 14:58 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 2, 2023 16:15 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 2, 2023 16:15 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 2, 2023 16:29 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 2, 2023 16:29 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl force-pushed the ryermilov/source-zendesk-support-add-availability-strategy branch from 1507c4b to 9ae8146 Compare February 2, 2023 20:15
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 2, 2023 20:17 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 2, 2023 20:17 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.52%

@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 2, 2023 21:58 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 2, 2023 21:58 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 2, 2023 23:31 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 2, 2023 23:31 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 3, 2023 07:19 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 3, 2023 07:19 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 3, 2023 08:41 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 3, 2023 08:41 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 3, 2023 09:45 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 3, 2023 09:45 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 3, 2023 11:04 — with GitHub Actions Inactive
@roman-yermilov-gl roman-yermilov-gl temporarily deployed to more-secrets February 3, 2023 11:04 — with GitHub Actions Inactive
@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Feb 3, 2023

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4083562468
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4083562468
Python tests coverage:

Name                                                           Stmts   Miss  Cover
----------------------------------------------------------------------------------
source_zendesk_support/__init__.py                                 2      0   100%
source_zendesk_support/source.py                                  56      6    89%
source_zendesk_support/streams.py                                398     43    89%
source_zendesk_support/ZendeskSupportAvailabilityStrategy.py      10      6    40%
----------------------------------------------------------------------------------
TOTAL                                                            466     55    88%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 44 passed, 3 skipped in 938.22s (0:15:38) ===================

Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the availabilitystrategy looks good. However can we split these into separate PRs? There is a lot going on here, and it'd be good to be able to easily revert an enhancement (adding availabilitystrategy) without also reverting fixing expected records, fixing configured catalog, etc

@roman-yermilov-gl roman-yermilov-gl force-pushed the ryermilov/source-zendesk-support-add-availability-strategy branch from fbd9e82 to b38b9d0 Compare February 7, 2023 12:23
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 7, 2023
@roman-yermilov-gl
Copy link
Contributor Author

I think the availabilitystrategy looks good. However can we split these into separate PRs? There is a lot going on here, and it'd be good to be able to easily revert an enhancement (adding availabilitystrategy) without also reverting fixing expected records, fixing configured catalog, etc

Done: #22483

@lazebnyi lazebnyi linked an issue Feb 8, 2023 that may be closed by this pull request
@lazebnyi lazebnyi removed the request for review from pedroslopez February 23, 2023 10:49
@roman-yermilov-gl roman-yermilov-gl force-pushed the ryermilov/source-zendesk-support-add-availability-strategy branch from b38b9d0 to 3a4dc8a Compare February 27, 2023 21:17
@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Feb 27, 2023

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4287536944
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4287536944
Python tests coverage:

Name                                                           Stmts   Miss  Cover
----------------------------------------------------------------------------------
source_zendesk_support/__init__.py                                 2      0   100%
source_zendesk_support/streams.py                                399     39    90%
source_zendesk_support/source.py                                  56      8    86%
source_zendesk_support/ZendeskSupportAvailabilityStrategy.py      10      6    40%
----------------------------------------------------------------------------------
TOTAL                                                            467     53    89%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 44 passed, 3 skipped in 760.38s (0:12:40) ===================

@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Feb 27, 2023

/publish connector=connectors/source-zendesk-support

🕑 Publishing the following connectors:
connectors/source-zendesk-support
https://github.com/airbytehq/airbyte/actions/runs/4287905244


Connector Did it publish? Were definitions generated?
connectors/source-zendesk-support

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@roman-yermilov-gl roman-yermilov-gl merged commit 33eed67 into master Feb 28, 2023
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-zendesk-support-add-availability-strategy branch February 28, 2023 00:28
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
* Source Zendesk Support: add availability strategy

* Source Zendesk Support: bump version, update changelog

* Automated Change

* auto-bump connector version

---------

Co-authored-by: roman-yermilov-gl <roman-yermilov-gl@users.noreply.github.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zendesk-support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Zendesk Support: Enable AvailabilityStrategy
4 participants