Source Zendesk Support: fix tests #22483

roman-yermilov-gl · 2023-02-07T12:36:41Z

What

fix tests

github-actions · 2023-02-07T12:45:39Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	24.67%	❌

roman-yermilov-gl · 2023-02-07T12:47:11Z

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4114034404
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4114034404
Python tests coverage:

Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_zendesk_support/__init__.py       2      0   100%
source_zendesk_support/streams.py      393     42    89%
source_zendesk_support/source.py        56      6    89%
--------------------------------------------------------
TOTAL                                  451     48    89%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     217    101    53%   37, 43-45, 50, 55, 78, 84, 90-92, 111, 116-118, 124-126, 132-133, 138-139, 144, 150, 159-168, 174-179, 194, 218, 249, 255, 263-271, 279-292, 300-313, 318-324, 331-342, 349-365
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1696    347    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 44 passed, 3 skipped in 387.66s (0:06:27) ===================

airbyte-integrations/connectors/source-zendesk-support/acceptance-test-config.yml

airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py

roman-yermilov-gl · 2023-02-08T19:41:07Z

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4127788404
❌ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4127788404
🐛 https://gradle.com/s/vqwqe5jyr633m

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream ticke...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
============= 1 failed, 43 passed, 3 skipped in 379.79s (0:06:19) ==============

roman-yermilov-gl · 2023-02-08T22:45:24Z

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4129079057
❌ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4129079057
🐛 https://gradle.com/s/2ij6ixc5ejnsa

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream ticke...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
============= 1 failed, 43 passed, 3 skipped in 399.98s (0:06:39) ==============

roman-yermilov-gl · 2023-02-08T23:57:57Z

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4129508282
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4129508282
Python tests coverage:

Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_zendesk_support/__init__.py       2      0   100%
source_zendesk_support/streams.py      393     42    89%
source_zendesk_support/source.py        56      6    89%
--------------------------------------------------------
TOTAL                                  451     48    89%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     217    101    53%   37, 43-45, 50, 55, 78, 84, 90-92, 111, 116-118, 124-126, 132-133, 138-139, 144, 150, 159-168, 174-179, 194, 218, 249, 255, 263-271, 279-292, 300-313, 318-324, 331-342, 349-365
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1696    347    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 44 passed, 3 skipped in 397.63s (0:06:37) ===================

erohmensing

No longer bypassing streams - Looks good 👍🏻

roman-yermilov-gl · 2023-02-10T13:20:24Z

/publish connector=connectors/source-zendesk-support

🕑 Publishing the following connectors:
connectors/source-zendesk-support
https://github.com/airbytehq/airbyte/actions/runs/4144274626

Connector	Did it publish?	Were definitions generated?
connectors/source-zendesk-support	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

roman-yermilov-gl · 2023-02-14T10:44:17Z

/approve-and-merge reason="Published before code freeze"

octavia-approvington · 2023-02-14T10:44:54Z

This code is at peace with itself

This reverts commit eaf7ec0.

cgardens · 2023-02-14T15:11:49Z

@roman-yermilov-gl you have merged this PR with a failing build. You cannot do that. The build must be green. I have reverted it.

roman-yermilov-gl requested review from erohmensing and lazebnyi February 7, 2023 12:36

roman-yermilov-gl self-assigned this Feb 7, 2023

octavia-squidington-iii added area/connectors Connector related issues connectors/source/zendesk-support labels Feb 7, 2023

roman-yermilov-gl temporarily deployed to more-secrets February 7, 2023 12:38 — with GitHub Actions Inactive

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 7, 2023

roman-yermilov-gl changed the title ~~Ryermilov/source zendesk support fix tests~~ Source Zendesk Support: fix tests Feb 7, 2023

roman-yermilov-gl temporarily deployed to more-secrets February 7, 2023 12:42 — with GitHub Actions Inactive

roman-yermilov-gl mentioned this pull request Feb 7, 2023

Source Zendesk Support: add availability strategy #22308

Merged

erohmensing reviewed Feb 7, 2023

View reviewed changes

lazebnyi requested a review from erohmensing February 7, 2023 18:02

roman-yermilov-gl force-pushed the ryermilov/source-zendesk-support-fix-tests branch from a08790c to 6553029 Compare February 8, 2023 19:32

roman-yermilov-gl temporarily deployed to more-secrets February 8, 2023 19:34 — with GitHub Actions Inactive

roman-yermilov-gl temporarily deployed to more-secrets February 8, 2023 23:55 — with GitHub Actions Inactive

lazebnyi approved these changes Feb 9, 2023

View reviewed changes

erohmensing approved these changes Feb 10, 2023

View reviewed changes

airbyteio requested a review from a team as a code owner February 10, 2023 13:44

octavia-squidington-iii added the normalization label Feb 10, 2023

airbyteio temporarily deployed to more-secrets February 10, 2023 13:46 — with GitHub Actions Inactive

octavia-squidington-iii removed the normalization label Feb 10, 2023

lazebnyi temporarily deployed to more-secrets February 10, 2023 14:41 — with GitHub Actions Inactive

roman-yermilov-gl force-pushed the ryermilov/source-zendesk-support-fix-tests branch from 278d114 to 5f6cb40 Compare February 14, 2023 10:30

roman-yermilov-gl added 5 commits February 14, 2023 14:31

Source Zendesk Support: fix tests

0b90f9f

Source Zendesk Support: bump version

7fd648a

Source Zendesk Support: update changelog

a6e5183

Source Zendesk Support: update expected records

5f80944

Source Zendesk Support: update expected records

5f6cb40

octavia-approvington approved these changes Feb 14, 2023

View reviewed changes

octavia-approvington merged commit eaf7ec0 into master Feb 14, 2023

octavia-approvington deleted the ryermilov/source-zendesk-support-fix-tests branch February 14, 2023 10:44

cgardens added a commit that referenced this pull request Feb 14, 2023

Revert "Source Zendesk Support: fix tests (#22483)"

ee2ad5d

This reverts commit eaf7ec0.

cgardens mentioned this pull request Feb 14, 2023

Revert "Source Zendesk Support: fix tests" #23007

Merged

cgardens added a commit that referenced this pull request Feb 14, 2023

Revert "Source Zendesk Support: fix tests (#22483)" (#23007)

dacd6fa

This reverts commit eaf7ec0.

lazebnyi mentioned this pull request Feb 22, 2023

Source Zendesk Support: handle 400 error for tickets stream #23246

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Zendesk Support: fix tests #22483

Source Zendesk Support: fix tests #22483

roman-yermilov-gl commented Feb 7, 2023

github-actions bot commented Feb 7, 2023 •

edited

Loading

roman-yermilov-gl commented Feb 7, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 8, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 8, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 8, 2023 •

edited by github-actions bot

Loading

erohmensing left a comment

roman-yermilov-gl commented Feb 10, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 14, 2023

octavia-approvington commented Feb 14, 2023

cgardens commented Feb 14, 2023

Source Zendesk Support: fix tests #22483

Source Zendesk Support: fix tests #22483

Conversation

roman-yermilov-gl commented Feb 7, 2023

What

github-actions bot commented Feb 7, 2023 • edited Loading

Airbyte Code Coverage

roman-yermilov-gl commented Feb 7, 2023 • edited by github-actions bot Loading

Build Passed

roman-yermilov-gl commented Feb 8, 2023 • edited by github-actions bot Loading

Build Failed

roman-yermilov-gl commented Feb 8, 2023 • edited by github-actions bot Loading

Build Failed

roman-yermilov-gl commented Feb 8, 2023 • edited by github-actions bot Loading

Build Passed

erohmensing left a comment

Choose a reason for hiding this comment

roman-yermilov-gl commented Feb 10, 2023 • edited by github-actions bot Loading

roman-yermilov-gl commented Feb 14, 2023

octavia-approvington commented Feb 14, 2023

cgardens commented Feb 14, 2023

github-actions bot commented Feb 7, 2023 •

edited

Loading

roman-yermilov-gl commented Feb 7, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 8, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 8, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 8, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 10, 2023 •

edited by github-actions bot

Loading