switch catalog discovery and syncs to temporal #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhizor
changed the title
cgardens
approved these changes
Mar 5, 2021
| @@ -112,4 +115,18 @@ public static StandardTargetConfig syncToTargetConfig(StandardSyncInput sync) { | |||
| .withState(sync.getState()); | |||
| } | |||
|
|
|||
| // todo (cgardens) - there are 2 sources of truth for job path. we need to reduce this down to one, | |||
| // once we are fully on temporal. | |||
| public static Path getJobRoot(Path workspaceRoot, IntegrationLauncherConfig launcherConfig) { | |||
There was a problem hiding this comment.
good call. I think you can replace the code in WorkerRun on line 52 with this too. gives us a better chance of making sure we get the paths right in temporal and outside of it.
|
This is working end to end locally in my testing. Need to fix the build + one comment and this should be ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add discovery + syncs + very minor refactors