Source Woocommerce: fix pagination and removed lookback window

[andrewlreeve]

What

1. The current version (0.2.0) of the Woocommerce connector has broken pagination and it is not fetching paginated pages.

2. A conversion window config has been included in the source that isn't required. This looks like a copy and paste hangover from a Google Ads connector.

How

1. Connector was using page instead of offset for the page_token_option. Woocommerce has to use an offset approach as the page index is 1 based.

🚨 User Impact 🚨

Removes a setting config that is superfluous.

Pre-merge Checklist

Community member or Airbyter

• Community member? Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • docs/integrations/README.md
  • airbyte-integrations/builds.md
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.
• /test connector=connectors/<name> command is passing
• New Connector version released on Dockerhub by running the /publish command described here
• After the connector is published, connector added to connector index as described here
• Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

• Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.
• /test connector=connectors/<name> command is passing
• New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

• Issue acceptance criteria met
• PR name follows PR naming conventions
• If adding a new generator, add it to the list of scaffold modules being tested
• The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
• Documentation which references the generator is updated as needed

[CLAassistant]

All committers have signed the CLA.

[marcosmarxm]

/test connector=connectors/source-woocommerce

🕑 connectors/source-woocommerce https://github.com/airbytehq/airbyte/actions/runs/4317218130
✅ connectors/source-woocommerce https://github.com/airbytehq/airbyte/actions/runs/4317218130
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 36 passed, 1 skipped in 346.36s (0:05:46) ===================

[marcosmarxm]

Thanks @andrewlreeve I'll publish tomorrow

[marcosmarxm]

/publish connector=connectors/source-woocommerce

🕑 Publishing the following connectors:
connectors/source-woocommerce
https://github.com/airbytehq/airbyte/actions/runs/4324525251

Connector	Did it publish?	Were definitions generated?
connectors/source-woocommerce	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️