Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Woocommerce: fix pagination and removed lookback window #23599

Merged
merged 6 commits into from
Mar 3, 2023
Merged

Source Woocommerce: fix pagination and removed lookback window #23599

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
56cf42a
fix: pagination and lookback
andrewlreeve Feb 28, 2023
54a9d73
chore: fix newline
andrewlreeve Feb 28, 2023
c0db8e0
bump connector version
marcosmarxm Mar 3, 2023
340b904
remove files and eof
marcosmarxm Mar 3, 2023
cb6598a
solve conflict
marcosmarxm Mar 3, 2023
e8ca19d
auto-bump connector version
octavia-squidington-iii Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions airbyte-integrations/connectors/source-woocommerce/sample_files/configured_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"streams": [
{
"stream": {
"name": "customers",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"]
},
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
}
]
}

3 changes: 1 addition & 2 deletions airbyte-integrations/connectors/source-woocommerce/source_woocommerce/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ definitions:
dates_are_gmt: "true"
date_incremental_sync:
type: DatetimeBasedCursor
lookback_window: "P{{ config.get('conversion_window_days', 0) }}D"
start_datetime:
datetime: "{{ format_datetime(config['start_date'], '%Y-%m-%dT%H:%M:%S') }}"
datetime_format: "%Y-%m-%dT%H:%M:%S"
Expand Down Expand Up @@ -48,7 +47,7 @@ definitions:
page_token_option:
type: RequestOption
inject_into: "request_parameter"
field_name: "page"
field_name: "offset"
page_size_option:
inject_into: "request_parameter"
field_name: "per_page"
Expand Down
11 changes: 1 addition & 10 deletions airbyte-integrations/connectors/source-woocommerce/source_woocommerce/spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,4 @@ connectionSpecification:
- "2021-01-01"
pattern: "^[0-9]{4}-[0-9]{2}-[0-9]{2}$"
order: 3
conversion_window_days:
type: integer
title: Conversion Window
description: A conversion window is the period of time after an ad interaction (such as an ad click or video view) during which a conversion, such as a purchase, is recorded in Google Ads
order: 4
minimum: 0
maximum: 1095
default: 0
examples:
- 14