Temporal Worker Wrapper #2368
Merged
Temporal Worker Wrapper #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
commented
Mar 9, 2021
| @@ -52,33 +60,49 @@ public WorkerRun create(Job job) { | |||
| return WorkerRun.create(workspaceRoot, job.getId(), attemptId, createSupplier(job, attemptId)); | |||
| } | |||
|
|
|||
| @SuppressWarnings("UnnecessaryDefault") | |||
| @SuppressWarnings({"UnnecessaryDefault", "CodeBlock2Expr"}) | |||
There was a problem hiding this comment.
the formatting makes this really hard to read if you don't have the return statements (even though the bracket-less lambda syntax is technically possible in this case).
cgardens
force-pushed
the
cgardens/tng_worker10
branch
from
cd59d03
to
6a65ad1
Compare
cgardens
commented
Mar 9, 2021
| * outputs are passed to the selected worker. It also makes sures that the outputs of the worker are | ||
| * persisted to the db. | ||
| */ | ||
| public class TemporalAttemptExecution<T> implements CheckedSupplier<T, TemporalJobException> { |
There was a problem hiding this comment.
I wanted to with a base temporal activity that could be extend to maximize how much code we could de-duplicate, but i couldn't find a version of it that i liked. it is particularly tricky given the interfaces that you need to work around with temporal. instead I did the TemporalAttemptExecution wrapper.
jrhizor
approved these changes
Mar 9, 2021
cgardens
force-pushed
the
cgardens/tng_worker10
branch
from
1162859
to
df09fa0
Compare
cgardens
force-pushed
the
cgardens/tng_worker10
branch
from
df09fa0
to
6a90ebb
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Workers when executed in Temporal. Specifically move all the logic for 1. job root / log paths 2. MDCs 3. error handling in one place, so it can all be tested once.How
Workers inTemporalAttemptExecution.Pre-merge Checklist
Recommended reading order
TemporalAttemptExecution.java