Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix json handling in http-request #2377

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

jrhizor
Copy link
Contributor

@jrhizor jrhizor commented Mar 9, 2021

Some web servers don't work when making the request if the JSON body isn't sent in this way via the requests library. This should fix the case shown in https://airbytehq.slack.com/archives/C01MFR03D5W/p1615203762192500

@jrhizor
Copy link
Contributor Author

jrhizor commented Mar 9, 2021

/publish connector=connectors/source-http-request

🕑 connectors/source-http-request https://github.com/airbytehq/airbyte/actions/runs/636493136
✅ connectors/source-http-request https://github.com/airbytehq/airbyte/actions/runs/636493136

@jrhizor jrhizor requested a review from cgardens March 9, 2021 16:53
@jrhizor jrhizor merged commit 4c22b9b into master Mar 9, 2021
@jrhizor jrhizor deleted the jrhizor/fix-json-handling-http-request branch March 9, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants