Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalization Bigquery: Add more reserved words #24077

Merged
merged 6 commits into from
Mar 15, 2023

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Mar 14, 2023

@edgao edgao requested a review from a team as a code owner March 14, 2023 23:08
@edgao
Copy link
Contributor Author

edgao commented Mar 14, 2023

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/4421021657

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2023

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

❌ Destinations (16)

Connector Version Changelog Publish
destination-bigquery 1.2.16
destination-bigquery-denormalized 1.2.16
destination-clickhouse 0.2.2
destination-clickhouse-strict-encrypt 0.2.2 🔵
(ignored)
🔵
(ignored)
destination-jdbc 0.3.14 🔵
(ignored)
🔵
(ignored)
destination-mssql 0.1.22
destination-mssql-strict-encrypt 0.1.22 🔵
(ignored)
🔵
(ignored)
destination-mysql 0.1.20
destination-mysql-strict-encrypt 0.1.21
(mismatch: 0.1.20)
🔵
(ignored)
🔵
(ignored)
destination-oracle 0.1.19
destination-oracle-strict-encrypt 0.1.19 🔵
(ignored)
🔵
(ignored)
destination-postgres 0.3.26
destination-postgres-strict-encrypt 0.3.26 🔵
(ignored)
🔵
(ignored)
destination-redshift 0.4.2
destination-snowflake 0.4.53
destination-tidb 0.1.0
  • See "Actionable Items" below for how to resolve warnings and errors.

👀 Other Modules (1)

  • base-normalization

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@edgao
Copy link
Contributor Author

edgao commented Mar 15, 2023

all failed tests were from mssql

         FAILED integration_tests/test_drop_scd_overwrite.py::test_reset_scd_on_overwrite[DestinationType.MSSQL]
         FAILED integration_tests/test_ephemeral.py::test_destination_supported_limits[DestinationType.MSSQL-1000]
         FAILED integration_tests/test_ephemeral.py::test_destination_failure_over_limits[MSSQL-1025-exceeds the maximum of 1024 columns.]
         FAILED integration_tests/test_ephemeral.py::test_empty_streams[DestinationType.MSSQL]
         FAILED integration_tests/test_ephemeral.py::test_stream_with_1_airbyte_column[DestinationType.MSSQL]
         FAILED integration_tests/***.py::***[DestinationType.MSSQL-test_simple_streams]
         FAILED integration_tests/***.py::***[DestinationType.MSSQL-test_nested_streams]
         ============ 7 failed, 41 ***ed, 14 skipped in 4003.71s (1:06:43) =============

which is actually because the destination connector is broken in some way:

com.microsoft.sqlserver.jdbc.SQLServerException: Incorrect syntax near 'ENFORCED'.
	at com.microsoft.sqlserver.jdbc.SQLServerException.makeFromDatabaseError(SQLServerException.java:262)
	at com.microsoft.sqlserver.jdbc.SQLServerStatement.getNextResult(SQLServerStatement.java:1632)
	at com.microsoft.sqlserver.jdbc.SQLServerStatement.doExecuteStatement(SQLServerStatement.java:872)
	at com.microsoft.sqlserver.jdbc.SQLServerStatement$StmtExecCmd.doExecute(SQLServerStatement.java:767)
	at com.microsoft.sqlserver.jdbc.TDSCommand.execute(IOBuffer.java:7375)
	at com.microsoft.sqlserver.jdbc.SQLServerConnection.executeCommand(SQLServerConnection.java:3206)
	at com.microsoft.sqlserver.jdbc.SQLServerStatement.executeCommand(SQLServerStatement.java:247)
	at com.microsoft.sqlserver.jdbc.SQLServerStatement.executeStatement(SQLServerStatement.java:222)
	at com.microsoft.sqlserver.jdbc.SQLServerStatement.execute(SQLServerStatement.java:743)
	at com.zaxxer.hikari.pool.ProxyStatement.execute(ProxyStatement.java:94)
	at com.zaxxer.hikari.pool.HikariProxyStatement.execute(HikariProxyStatement.java)
	at io.airbyte.db.jdbc.JdbcDatabase.lambda$execute$0(JdbcDatabase.java:49)
	at io.airbyte.db.jdbc.DefaultJdbcDatabase.execute(DefaultJdbcDatabase.java:46)
	at io.airbyte.db.jdbc.JdbcDatabase.execute(JdbcDatabase.java:49)
	at io.airbyte.integrations.destination.mssql.SqlServerOperations.createTableIfNotExists(SqlServerOperations.java:29)
	at io.airbyte.integrations.destination.jdbc.JdbcBufferedConsumerFactory.lambda$onStartFunction$1(JdbcBufferedConsumerFactory.java:131)
	at io.airbyte.commons.concurrency.VoidCallable.call(VoidCallable.java:15)
	at io.airbyte.integrations.destination.buffered_stream_consumer.BufferedStreamConsumer.startTracked(BufferedStreamConsumer.java:147)
	at io.airbyte.integrations.base.FailureTrackingAirbyteMessageConsumer.start(FailureTrackingAirbyteMessageConsumer.java:43)
	at io.airbyte.integrations.base.AirbyteMessageConsumer$1.start(AirbyteMessageConsumer.java:60)
	at io.airbyte.integrations.base.IntegrationRunner.consumeWriteStream(IntegrationRunner.java:200)
	at io.airbyte.integrations.base.IntegrationRunner.lambda$runConsumer$2(IntegrationRunner.java:208)
	at io.airbyte.integrations.base.IntegrationRunner.watchForOrphanThreads(IntegrationRunner.java:237)
	at io.airbyte.integrations.base.IntegrationRunner.runConsumer(IntegrationRunner.java:207)
	at io.airbyte.integrations.base.IntegrationRunner.runInternal(IntegrationRunner.java:148)
	at io.airbyte.integrations.base.IntegrationRunner.run(IntegrationRunner.java:98)
	at io.airbyte.integrations.destination.mssql.MSSQLDestination.main(MSSQLDestination.java:103)

I'm going to publish with run-tests=false.

@edgao
Copy link
Contributor Author

edgao commented Mar 15, 2023

/publish connector=bases/base-normalization run-tests=false

🕑 Publishing the following connectors:
bases/base-normalization
https://github.com/airbytehq/airbyte/actions/runs/4429210268


Connector Did it publish? Were definitions generated?
bases/base-normalization

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 15, 2023
@edgao edgao enabled auto-merge (squash) March 15, 2023 17:45
@edgao edgao merged commit 294cdbc into master Mar 15, 2023
@edgao edgao deleted the edgao/normalization_bq_reserved_words branch March 15, 2023 18:34
adriennevermorel pushed a commit to adriennevermorel/airbyte that referenced this pull request Mar 17, 2023
* add current times for bigquery

* bump version + changelog
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
* add current times for bigquery

* bump version + changelog
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
* add current times for bigquery

* bump version + changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation normalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants