Destination MSSQL: make Azure Synapse Compatibility In Test

[chte]

What

Describe what the change is solving
Make MSSQL integration test compatible with Azure Synapse

It helps to add screenshots if it affects the frontend.

How

Describe the solution

For Azure DWH a primary key cannot be enforced in Azure DWH. I am only a first day user, I don't entirely know the framework and ideally this should be it's own connector and not lumped together with all MSSQL version.

and this is not tested if non Azure DWH SQL support this constrants

🚨 User Impact 🚨

You can not configure Azure Synapse DWH as a destination

Pre-merge Checklist

I am only a first day user, I don't entirely know the framework and ideally this should be it's own connector and not lumped together with all MSSQL versions. This solution might break other versions of MSSQL and is not tested.

New Connector

Community member or Airbyter

• Community member? Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • docs/integrations/README.md
  • airbyte-integrations/builds.md
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.
• /test connector=connectors/<name> command is passing
• New Connector version released on Dockerhub by running the /publish command described here
• After the connector is published, connector added to connector index as described here
• Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

• Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
• PR name follows PR naming conventions

[CLAassistant]

All committers have signed the CLA.

[sajarin]

@chte thanks for the PR. Can you sign the CLA?

[marcosmarxm]

Hello 👋, first thank you for this amazing contribution.

We really appreciate the effort you've made to improve the project.
We ask you patience for the code review. Last month our team was focused on Hacktoberfest event and that probably left some PR without the proper feedback. And this week, due to the Thanksgiving US Holiday, most our team is out of office with their families. Another important piece of information why code won't be merge this week is: as a safety measure the core team has decided to freeze merging code to main branch to keep the release stable. Next week we'll return to you with the proper code review and update the status of your contribution.

If you have any questions feel free to send me a message in Slack!
Thanks!

[marcosmarxm]

/test connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/3605594554
❌ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/3605594554
🐛 https://gradle.com/s/ap7yuqkjxn2lo

Build Failed

Test summary info:

Could not find result summary

[marcosmarxm]

Hello 👋:skin-tone-2: and thank you for your contribution!

Airbyte has instituted a code freeze between 19 and 30 December, to make sure there are no disruptions during the holidays.
Because of this, reviewing and merging your contribution may take longer than usual.
We apologize for the delay, but we want everyone to have a quiet and happy holiday.

If you have any questions or need further clarification, please don't hesitate to ping via Slack.

[marcosmarxm]

@grishick This is a small change to MSSL. Can it be added to destination team backlog to review and validate it?

[grishick]

PR to run CI: #23851

[grishick]

Integration tests for destionation-mssql are broken and I verified other CI checks on this PR

[edgao]

@grishick I think this might not work for non-dwh destinations - #24077 (comment)

so we might need to make a new connector. Or at least add a config flag for "this is running in azure dwh and needs special handling"

base-normalization integration tests are also failing for mssql, with Incorrect syntax near 'ENFORCED'. I'd expect that the destination-mssql tests are seeing the same error, which was hidden behind some other (unfortunately expected) test failures

either way - this change hasn't been published yet, so not an urgent thing to solve

[grishick]

yep. We have to revert this change and make a new connector for Azure Synapse