🐛 Source Insightly: fix remove timedelta for incremental causing missing records

[henriblancke]

What

Adding 1 second to the cursor value can occasionally cause missing records. There is no clear indication in the insightly docs if providing anupdated_after_utc is > or >=. In any case having an occasional duplicate is better than missing records.

How

Don't add 1 second to the cursor value before retrieving data incrementally

Recommended reading order

1. x.java
2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

• Community member? Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Connector version is set to 0.0.1
  • Dockerfile has version 0.0.1
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
  • docs/integrations/README.md
  • airbyte-integrations/builds.md
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.
• /test connector=connectors/<name> command is passing
• New Connector version released on Dockerhub by running the /publish command described here
• After the connector is published, connector added to connector index as described here
• Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

• Grant edit access to maintainers (instructions)

• Secrets in the connector's spec are annotated with airbyte_secret

• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.

• Code reviews completed

• Connector version has been incremented

  • Version has been bumped according to our Semantic Versioning for Connectors guidelines
  • Dockerfile has updated version

• Documentation updated

  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example

• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.
• /test connector=connectors/<name> command is passing
• New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

• Issue acceptance criteria met
• PR name follows PR naming conventions
• If adding a new generator, add it to the list of scaffold modules being tested
• The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
• Documentation which references the generator is updated as needed

[sajarin]

/test connector=connectors/source-insightly

🕑 connectors/source-insightly https://github.com/airbytehq/airbyte/actions/runs/4622284619
✅ connectors/source-insightly https://github.com/airbytehq/airbyte/actions/runs/4622284619
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_insightly/__init__.py       2      0   100%
source_insightly/source.py       214     46    79%
--------------------------------------------------
TOTAL                            216     46    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
======================== 38 passed, 2 skipped in 42.98s ========================

[sajarin]

Thanks for the PR @henriblancke this looks good to me. For future reference, in case someone does want to try to fix the connector so that it doesn't produce duplicate records (while also not producing missing records), what can be done to figure out whether or not the updated_after_utc is inclusive or exclusive?

[sajarin]

/publish connector=connectors/source-insightly

🕑 Publishing the following connectors:
connectors/source-insightly
https://github.com/airbytehq/airbyte/actions/runs/4632649170

Connector	Did it publish?	Were definitions generated?
connectors/source-insightly	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

[sajarin]

@henriblancke can you fix the merge conflicts here? I'm guessing there needs to be a rebase with master.

[henriblancke]

Thanks for the PR @henriblancke this looks good to me. For future reference, in case someone does want to try to fix the connector so that it doesn't produce duplicate records (while also not producing missing records), what can be done to figure out whether or not the updated_after_utc is inclusive or exclusive?

@sajarin I'll have our team reach out to their tech team and hopefully get a clear answer on the expected behavior.

@henriblancke can you fix the merge conflicts here? I'm guessing there needs to be a rebase with master.

Should be rebased and merge conflicts are fixed

[sajarin]

Thanks for the contribution @henriblancke!