🐛 Source insightly: Make incremental logic inclusive

[henriblancke]

What

After talking to the insightly dev team we learned that the UTC search paramater is exclusive.

How

Since it goes down to the second remove 1 second from the cursor timestamp to make it inclusive.

This is a follow up to: #24422 (comment)

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

• Community member? Grant edit access to maintainers (instructions)
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Connector version is set to 0.0.1
  • Dockerfile has version 0.0.1
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
  • docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.

Updating a connector

Community member or Airbyter

• Grant edit access to maintainers (instructions)
• Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.

Connector Generator

• Issue acceptance criteria met
• PR name follows PR naming conventions
• If adding a new generator, add it to the list of scaffold modules being tested
• The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
• Documentation which references the generator is updated as needed

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
• You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
• You've updated the connector's metadata.yaml file new!

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

[henriblancke]

@sajarin this is a follow up to your comment here: #24422 (comment)

[marcosmarxm]

Some comments.

[henriblancke]

@marcosmarxm thanks for the review! I've addressed your comments

[marcosmarxm]

/test connector=connectors/source-insightly

🕑 connectors/source-insightly https://github.com/airbytehq/airbyte/actions/runs/4983589130
✅ connectors/source-insightly https://github.com/airbytehq/airbyte/actions/runs/4983589130
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_insightly/__init__.py       2      0   100%
source_insightly/source.py       215     38    82%
--------------------------------------------------
TOTAL                            217     38    82%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
======================== 38 passed, 2 skipped in 34.84s ========================

[marcosmarxm]

/publish connector=connectors/source-insightly

🕑 Publishing the following connectors:
connectors/source-insightly
https://github.com/airbytehq/airbyte/actions/runs/5026348300

Connector	Version	Did it publish?
connectors/source-insightly	0.1.3	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️