Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish normalization #25591

Merged
merged 5 commits into from
Apr 28, 2023
Merged

publish normalization #25591

merged 5 commits into from
Apr 28, 2023

Conversation

jcowanpdx
Copy link
Contributor

What

Publish Normalization

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Connector version is set to 0.0.1
    • Dockerfile has version 0.0.1
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)

  • Secrets in the connector's spec are annotated with airbyte_secret

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.

  • Code reviews completed

  • Connector version has been incremented

  • Documentation updated

    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

@jcowanpdx
Copy link
Contributor Author

jcowanpdx commented Apr 26, 2023

/publish connector=bases/base-normalization run-test=false

Error: Unexpected inputs provided: ["run-test"]

@jcowanpdx
Copy link
Contributor Author

jcowanpdx commented Apr 26, 2023

/publish connector=bases/base-normalization run-tests=false

🕑 Publishing the following connectors:
bases/base-normalization
https://github.com/airbytehq/airbyte/actions/runs/4814297746


Connector Version Did it publish? Were definitions generated?
bases/base-normalization

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@jcowanpdx jcowanpdx requested review from edgao and ryankfu April 26, 2023 23:51
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 27, 2023
@jcowanpdx jcowanpdx enabled auto-merge (squash) April 27, 2023 00:37
Copy link
Contributor

@ryankfu ryankfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems it did not auto-merge because of the "Automated changes" you'll want to force-push with the normalizationTag bumps. Usually whenever an "Automated change" occurs it won't run the builds necessary to unblock the pipeline

@jcowanpdx jcowanpdx disabled auto-merge April 28, 2023 16:47
@jcowanpdx jcowanpdx merged commit bdca4cd into master Apr 28, 2023
@jcowanpdx jcowanpdx deleted the jeff/publish-normalization branch April 28, 2023 20:17
edgao added a commit that referenced this pull request Apr 28, 2023
* publish normalization
* bump normalization container version in all the destinations that use it

Co-authored-by: Edward Gao <edward.gao@airbyte.io>
Co-authored-by: edgao <edgao@users.noreply.github.com>
edgao added a commit that referenced this pull request May 5, 2023
* map the other integer schema to long

* fix test + add test

* delete_public_access_block for bucket if public (#25663)

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

* 🐛 Source Facebook Marketing: fix `expected records` for  CAT (#25604)

* publish normalization (#25591)

* publish normalization
* bump normalization container version in all the destinations that use it

Co-authored-by: Edward Gao <edward.gao@airbyte.io>
Co-authored-by: edgao <edgao@users.noreply.github.com>

* Bump Airbyte version from 0.44.2 to 0.44.3

* Destination Bigquery: update AIRBYTE_ENTRYPOINT env var for kube process (#25588)

* add AIRBYTE_ENTRYPOINT env var for kube

* amazing, absolute genius

* version bump + changelog

* derp, no need to publish denormalizeid

* fix changelog entry

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

* version bumps + changelog

* whoops

* bump metadata

* bump metadatas

* auto-bump connector version

* auto-bump connector version

* auto-bump connector version

* auto-bump connector version

* auto-bump connector version

---------

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Co-authored-by: Serhii Chvaliuk <grubberr@gmail.com>
Co-authored-by: Baz <oleksandr.bazarnov@globallogic.com>
Co-authored-by: Jeff Cowan (Airbyte) <4992320+jcowanpdx@users.noreply.github.com>
Co-authored-by: edgao <edgao@users.noreply.github.com>
Co-authored-by: benmoriceau <benmoriceau@users.noreply.github.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* publish normalization
* bump normalization container version in all the destinations that use it

Co-authored-by: Edward Gao <edward.gao@airbyte.io>
Co-authored-by: edgao <edgao@users.noreply.github.com>
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
…#25570)

* map the other integer schema to long

* fix test + add test

* delete_public_access_block for bucket if public (airbytehq#25663)

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

* 🐛 Source Facebook Marketing: fix `expected records` for  CAT (airbytehq#25604)

* publish normalization (airbytehq#25591)

* publish normalization
* bump normalization container version in all the destinations that use it

Co-authored-by: Edward Gao <edward.gao@airbyte.io>
Co-authored-by: edgao <edgao@users.noreply.github.com>

* Bump Airbyte version from 0.44.2 to 0.44.3

* Destination Bigquery: update AIRBYTE_ENTRYPOINT env var for kube process (airbytehq#25588)

* add AIRBYTE_ENTRYPOINT env var for kube

* amazing, absolute genius

* version bump + changelog

* derp, no need to publish denormalizeid

* fix changelog entry

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

* version bumps + changelog

* whoops

* bump metadata

* bump metadatas

* auto-bump connector version

* auto-bump connector version

* auto-bump connector version

* auto-bump connector version

* auto-bump connector version

---------

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Co-authored-by: Serhii Chvaliuk <grubberr@gmail.com>
Co-authored-by: Baz <oleksandr.bazarnov@globallogic.com>
Co-authored-by: Jeff Cowan (Airbyte) <4992320+jcowanpdx@users.noreply.github.com>
Co-authored-by: edgao <edgao@users.noreply.github.com>
Co-authored-by: benmoriceau <benmoriceau@users.noreply.github.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants