fix file clean up for BigQueue #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhizor
approved these changes
Mar 23, 2021
|
How'd you run across this? |
|
i was reading about using bigqueue for notifications and while i was reading about it i noticed the contract it had around cleaning up and that the way we were doing it was insufficient. pretty random. 🤷♀️ |
cgardens
force-pushed
the
cgardens/fix_bigqueue_close
branch
from
36483ff
to
88a9728
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
While reading through our usage of BigQueue, I realized that it might not clean up properly in error cases.
gconly deletes "used" files. So in an error case where some of the underlying files haven't been consumed yet from the queue, then they would not be deleted.How
Replace it by blowing away the entire persistence layer. If we ever want to use BigQueue to persist data across processes, then we will need to rethink it, but the way we are wrapping it now this should be safe.