-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Facebook Marketing: handle config errors #26000
Source Facebook Marketing: handle config errors #26000
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
/test connector=connectors/source-facebook-marketing
Build FailedTest summary info:
|
/test connector=connectors/source-facebook-marketing
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Even if this is a pattern addition restricting the input I think this is backward compatible because no user should have correctly set up an account id with inputs not matching the pattern so far.
/publish connector=connectors/source-facebook-marketing
if you have connectors that successfully published but failed definition generation, follow step 4 here |
…-errors-25686 # Conflicts: # airbyte-config-oss/init-oss/src/main/resources/seed/oss_registry.json
…-errors-25686 # Conflicts: # airbyte-config-oss/init-oss/src/main/resources/seed/oss_registry.json
…ing-config-errors-25686' into artem1205/source-facebook-marketing-config-errors-25686
* Source Facebook Marketing: handle account ID * Source Facebook Marketing: handle wrong account id * Source Facebook Marketing: refactor wrong insights fields in custom streams * Source Facebook Marketing: handle code 100 for wrong account * Automated Change --------- Co-authored-by: artem1205 <artem1205@users.noreply.github.com>
What
Resolve #25686
How
handle permission specific errors (
code
100
) asconfig_error
, validateaccountID
(digits only)Recommended reading order
x.java
y.python
🚨 User Impact 🚨
no breaking changes
Pre-merge Actions
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.