🐛Source GitHub: added description for no repos case error #26075

darynaishchenko · 2023-05-15T13:42:54Z

resolved: https://github.com/airbytehq/oncall/issues/1747
Problem:
In case when user provided repository name that do not exist in github, or just wrong name (typo for example), connector says that is repository config is invalid, which is not clear.
Solution:
Added description why config can be invalid to help user fix it.

github-actions · 2023-05-15T13:43:14Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
You've updated the connector's metadata.yaml file new!

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

darynaishchenko · 2023-05-15T15:46:20Z

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/4982422786
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/4982422786
Python tests coverage:

Name                             Stmts   Miss  Cover
----------------------------------------------------
source_github/github_schema.py    8807      0   100%
source_github/__init__.py            2      0   100%
source_github/utils.py              16      1    94%
source_github/streams.py           838     91    89%
source_github/graphql.py           167     22    87%
source_github/source.py            137     37    73%
----------------------------------------------------
TOTAL                             9967    151    98%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 47 passed, 3 skipped in 334.25s (0:05:34) ===================

airbyte-integrations/connectors/source-github/source_github/source.py

docs/integrations/sources/github.md

lazebnyi

LGTM! Minor changes needed.

lazebnyi · 2023-05-16T10:10:08Z

airbyte-integrations/connectors/source-github/source_github/source.py

@@ -234,7 +234,15 @@ def streams(self, config: Mapping[str, Any]) -> List[Stream]:
                raise e

        if not any((organizations, repositories)):
-            raise Exception("No streams available. Please check permissions")
+            user_message = (


Need add unit tests for this functionality.

darynaishchenko · 2023-05-16T11:29:54Z

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/4991320444
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/4991320444
Python tests coverage:

Name                             Stmts   Miss  Cover
----------------------------------------------------
source_github/github_schema.py    8807      0   100%
source_github/__init__.py            2      0   100%
source_github/utils.py              16      1    94%
source_github/streams.py           838     91    89%
source_github/graphql.py           167     22    87%
source_github/source.py            135     35    74%
----------------------------------------------------
TOTAL                             9965    149    99%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 47 passed, 3 skipped in 321.13s (0:05:21) ===================

darynaishchenko · 2023-05-16T13:09:13Z

/publish connector=connectors/source-github

🕑 Publishing the following connectors:
connectors/source-github
https://github.com/airbytehq/airbyte/actions/runs/4992301202

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-github	0.4.10	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…vailable

…26075) * added description for no repos case error * added AirbyteTracedException * added changelog * removed handling error in validation * updated github.md * added unit test test_streams_no_streams_available_error * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

added description for no repos case error

8035e72

darynaishchenko self-assigned this May 15, 2023

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 15, 2023

octavia-squidington-iii added the connectors/source/github label May 15, 2023

darynaishchenko marked this pull request as draft May 15, 2023 14:03

darynaishchenko added 2 commits May 15, 2023 18:43

added AirbyteTracedException

b5f5367

added changelog

576b2cf

darynaishchenko changed the title ~~Source GitHub: added description for no repos case error~~ 🐛Source GitHub: added description for no repos case error May 15, 2023

darynaishchenko marked this pull request as ready for review May 15, 2023 15:47

darynaishchenko requested review from grubberr and lazebnyi May 15, 2023 16:06

grubberr reviewed May 15, 2023

View reviewed changes

airbyte-integrations/connectors/source-github/source_github/source.py Outdated Show resolved Hide resolved

removed handling error in validation

a93239e

darynaishchenko force-pushed the daryna/source-github/exeption-no-streams-available branch from d79bd76 to a93239e Compare May 15, 2023 16:32

grubberr reviewed May 15, 2023

View reviewed changes

docs/integrations/sources/github.md Outdated Show resolved Hide resolved

updated github.md

1640027

darynaishchenko requested a review from grubberr May 15, 2023 17:46

lazebnyi approved these changes May 16, 2023

View reviewed changes

added unit test test_streams_no_streams_available_error

dd39bd3

auto-bump connector version

8e5a0cd

darynaishchenko added the checklist-action-run label May 16, 2023

Merge branch 'master' into daryna/source-github/exeption-no-streams-a…

5e9d679

…vailable

darynaishchenko merged commit 0599080 into master May 16, 2023

darynaishchenko deleted the daryna/source-github/exeption-no-streams-available branch May 16, 2023 15:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛Source GitHub: added description for no repos case error #26075

🐛Source GitHub: added description for no repos case error #26075

darynaishchenko commented May 15, 2023 •

edited

Loading

github-actions bot commented May 15, 2023 •

edited by darynaishchenko

Loading

darynaishchenko commented May 15, 2023 •

edited by github-actions bot

Loading

lazebnyi left a comment

lazebnyi May 16, 2023

darynaishchenko commented May 16, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented May 16, 2023 •

edited by github-actions bot

Loading

🐛Source GitHub: added description for no repos case error #26075

🐛Source GitHub: added description for no repos case error #26075

Conversation

darynaishchenko commented May 15, 2023 • edited Loading

github-actions bot commented May 15, 2023 • edited by darynaishchenko Loading

Before Merging a Connector Pull Request

darynaishchenko commented May 15, 2023 • edited by github-actions bot Loading

Build Passed

lazebnyi left a comment

Choose a reason for hiding this comment

lazebnyi May 16, 2023

Choose a reason for hiding this comment

darynaishchenko commented May 16, 2023 • edited by github-actions bot Loading

Build Passed

darynaishchenko commented May 16, 2023 • edited by github-actions bot Loading

darynaishchenko commented May 15, 2023 •

edited

Loading

github-actions bot commented May 15, 2023 •

edited by darynaishchenko

Loading

darynaishchenko commented May 15, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented May 16, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented May 16, 2023 •

edited by github-actions bot

Loading