🐛 Source Notion: migrated to advancedAuth

[darynaishchenko]

What

#26242

How

• Replace deprecated authSpecification with advancedAuth in the connector spec

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
• You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

[darynaishchenko]

/test connector=connectors/source-notion

🕑 connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/5078453011
❌ connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/5078453011
🐛 https://gradle.com/s/lxu2vyzdvub4w

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_backward_compatibility[inputs0] - hypothe...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream users...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 2 failed, 38 passed, 1 skipped in 122.78s (0:02:02) ==============

[davydov-d]

/test connector=connectors/source-notion

🕑 connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/5266559038
❌ connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/5266559038
🐛 https://gradle.com/s/t7qp5iviiuhry

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_backward_compatibility[inputs0] - hypothe...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:598: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first.
============= 1 failed, 39 passed, 2 skipped in 126.16s (0:02:06) ==============

[bnchrch]

@darynaishchenko I tried reproducing this locally with no success.

So what ive done (I hope you dont mind) is

1. Updated your branch to latest master
2. Which is rerunning the new test ci https://github.com/airbytehq/airbyte/actions/runs/5273620075/jobs/9537254967

Note that if this passes we should be goood!

also as of today /test has been deprecated and is no longer required.

[octavia-squidington-iii]

source-notion test report (commit 9f8677f81c) - ✅

⏲️ Total pipeline duration: 225 seconds

Step	Result
Validate airbyte-integrations/connectors/source-notion/metadata.yaml	✅
Connector version semver check.	✅
Connector version increment check.	✅
QA checks	✅
Connector package install	✅
Build source-notion docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-notion test

[davydov-d]

thanks @bnchrch!