-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAT: Ensure we only generate iso8601 with hypothesis in backwards compatibility test #26683
Conversation
Octavia Squidington III seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Affected Connector ReportNOTE
|
Connector | Version | Changelog | Publish |
---|---|---|---|
source-railz |
0.1.1 |
✅ | ✅ |
- See "Actionable Items" below for how to resolve warnings and errors.
✅ Destinations (0)
Connector | Version | Changelog | Publish |
---|
- See "Actionable Items" below for how to resolve warnings and errors.
✅ Other Modules (0)
Actionable Items
(click to expand)
Category | Status | Actionable Item |
---|---|---|
Version | ❌ mismatch |
The version of the connector is different from its normal variant. Please bump the version of the connector. |
⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
|
Changelog | ⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
❌ changelog missing |
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog. | |
Publish | ⚠ not in seed |
The connector is not in the cloud or oss registry, so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that you have added a metadata.yaml file and the expected registries are enabled. |
5210b3a
to
d9f0b54
Compare
@evantahler moving our slack convo here TLDR: That was a good callout that had me reevaluate my approach to this test The issue here is essentially In the case of both it blows up because many of the date-time strings do not match our pattern regex's as they are often very strict e.g. "^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}.[0-9]{3}Z$", I think our best solution to this is in the case of
How we do that is by removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me. Approving since this is blocking a roadmap item for GL
f501ef7
to
4345578
Compare
hey @bnchrch it looks like the problem still persists, could you please take a look? https://github.com/airbytehq/airbyte/actions/runs/5266559038/jobs/9520679064 |
Just closing the loop here as my reply yesterday was on the latest PR Essentially it looks like the problem is resolved! |
What
Ok so we have one GLOBAL problem of our formats do not match ALL valid ISO dates.
But lets ignore that.
The subproblem here is backwards compatibility tests are failing for the following reasons
format
fordate-time
in our specs are very strict about having 3 miliseconds (screenshot 2)This causes failing backwards compatibility tests (slack thread)
Solution
Only generate date-times that represent our valid version
blocks #26535