Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Source Asana: Fix order of authentication methods #26653

Merged
merged 4 commits into from
May 30, 2023
Merged

🐛Source Asana: Fix order of authentication methods #26653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23a93c7
Fix order of authentication methods
tolik0 May 26, 2023
951e672
Update changelog
tolik0 May 26, 2023
5546b31
Merge branch 'master' into 26518-source-asana-display-oauth-as-the-de…
tolik0 May 30, 2023
6b841d1
Add allowedHosts to metadata.yaml
tolik0 May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-asana/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.5
LABEL io.airbyte.version=0.1.6
LABEL io.airbyte.name=airbyte/source-asana
5 changes: 4 additions & 1 deletion airbyte-integrations/connectors/source-asana/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
data:
allowedHosts:
hosts:
- app.asana.com
connectorSubtype: api
connectorType: source
definitionId: d0243522-dccf-4978-8ba0-37ed47a0bdbf
dockerImageTag: 0.1.5
dockerImageTag: 0.1.6
dockerRepository: airbyte/source-asana
githubIssueLabel: source-asana
icon: asana.svg
Expand Down
40 changes: 20 additions & 20 deletions airbyte-integrations/connectors/source-asana/source_asana/spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,25 +11,6 @@
"description": "Choose how to authenticate to Github",
"type": "object",
"oneOf": [
{
"type": "object",
"title": "Authenticate with Personal Access Token",
"required": ["personal_access_token"],
"properties": {
"option_title": {
"type": "string",
"title": "Credentials title",
"description": "PAT Credentials",
"const": "PAT Credentials"
},
"personal_access_token": {
"type": "string",
"title": "Personal Access Token",
"description": "Asana Personal Access Token (generate yours <a href=\"https://app.asana.com/0/developer-console\">here</a>).",
"airbyte_secret": true
}
}
},
{
"type": "object",
"title": "Authenticate via Asana (Oauth)",
Expand Down Expand Up @@ -60,6 +41,25 @@
"airbyte_secret": true
}
}
},
{
"type": "object",
"title": "Authenticate with Personal Access Token",
"required": ["personal_access_token"],
"properties": {
"option_title": {
"type": "string",
"title": "Credentials title",
"description": "PAT Credentials",
"const": "PAT Credentials"
},
"personal_access_token": {
"type": "string",
"title": "Personal Access Token",
"description": "Asana Personal Access Token (generate yours <a href=\"https://app.asana.com/0/developer-console\">here</a>).",
"airbyte_secret": true
}
}
}
]
}
Expand All @@ -68,7 +68,7 @@
"authSpecification": {
"auth_type": "oauth2.0",
"oauth2Specification": {
"rootObject": ["credentials", 1],
"rootObject": ["credentials", 0],
"oauthFlowInitParameters": [["client_id"], ["client_secret"]],
"oauthFlowOutputParameters": [["refresh_token"]]
}
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/asana.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ The connector is restricted by normal Asana [requests limitation](https://develo

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :--------------------------------------------------------- |
| 0.1.6 | 2023-05-26 | [26653](https://github.com/airbytehq/airbyte/pull/26653) | Fix order of authentication methods |
| 0.1.5 | 2022-11-16 | [19561](https://github.com/airbytehq/airbyte/pull/19561) | Added errors handling, updated SAT with new format |
| 0.1.4 | 2022-08-18 | [15749](https://github.com/airbytehq/airbyte/pull/15749) | Add cache to project stream |
| 0.1.3 | 2021-10-06 | [6832](https://github.com/airbytehq/airbyte/pull/6832) | Add oauth init flow parameters support |
Expand Down
Loading