Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Source Asana: Fix order of authentication methods #26653

Merged

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented May 26, 2023

What

Fix the order of authentication methods, to make Oauth the default one.

Image

image

How

Change the order of authentication methods in spec

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@tolik0 tolik0 linked an issue May 26, 2023 that may be closed by this pull request
@CLAassistant
Copy link

CLAassistant commented May 26, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 26, 2023
@tolik0
Copy link
Contributor Author

tolik0 commented May 26, 2023

/test connector=connectors/source-asana

🕑 connectors/source-asana https://github.com/airbytehq/airbyte/actions/runs/5090021439
✅ connectors/source-asana https://github.com/airbytehq/airbyte/actions/runs/5090021439
Python tests coverage:

Name                       Stmts   Miss  Cover
----------------------------------------------
source_asana/oauth.py         10      0   100%
source_asana/__init__.py       2      0   100%
source_asana/streams.py      130      7    95%
source_asana/source.py        27      2    93%
----------------------------------------------
TOTAL                        169      9    95%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: As we are using an internal account the data is not frozen and results of `two-sequential-reads` are flaky. Please follow https://github.com/airbytehq/airbyte/issues/19662.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental syncs are not supported on this connector.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 35 passed, 3 skipped in 455.07s (0:07:35) ===================

@tolik0 tolik0 requested review from bazarnov and lazebnyi May 26, 2023 10:52
@bazarnov
Copy link
Collaborator

bazarnov commented May 26, 2023

@tolik0 Have you tested the appearance locally using Local Airbyte Instance (OSS)? Does it look as expected?

@tolik0
Copy link
Contributor Author

tolik0 commented May 26, 2023

@tolik0 Have you tested the appearance locally using Local Airbyte Instance (OSS)? Does it look as expected?

Yes, I added image to description of pr

@tolik0 tolik0 closed this May 30, 2023
@tolik0 tolik0 reopened this May 30, 2023
@tolik0 tolik0 enabled auto-merge (squash) May 30, 2023 07:42
@tolik0 tolik0 disabled auto-merge May 30, 2023 07:45
@tolik0 tolik0 requested a review from bazarnov May 30, 2023 09:07
@tolik0 tolik0 merged commit 462316b into master May 30, 2023
19 checks passed
@tolik0 tolik0 deleted the 26518-source-asana-display-oauth-as-the-default-auth-mechanism branch May 30, 2023 10:21
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* Fix the order of authentication methods to make OAuth default one 

* Add allowedHosts to metadata.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/asana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Asana: display oauth as the default auth mechanism
5 participants