Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Instagram: handle permission error #26767

Merged
merged 3 commits into from
May 30, 2023

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented May 30, 2023

What

Resolve:

Handle permission error and 2108006 should skip now, completely, instead of retries, because exp 7 retries are way too much for the heartbeat.

How

Skip insights with insufficient permissions

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

No breaking Changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 30, 2023
@artem1205
Copy link
Collaborator Author

artem1205 commented May 30, 2023

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/5123493914
✅ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/5123493914
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/source.py        31      0   100%
source_instagram/__init__.py       2      0   100%
source_instagram/common.py        36      1    97%
source_instagram/streams.py      218     14    94%
source_instagram/api.py           61      9    85%
--------------------------------------------------
TOTAL                            348     24    93%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/__init__.py       2      0   100%
source_instagram/api.py           61      7    89%
source_instagram/source.py        31     11    65%
source_instagram/streams.py      218    102    53%
source_instagram/common.py        36     22    39%
--------------------------------------------------
TOTAL                            348    142    59%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:212: Skipping new incremental test based on acceptance-test-config.yml
================== 37 passed, 3 skipped in 187.91s (0:03:07) ===================

Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@artem1205
Copy link
Collaborator Author

artem1205 commented May 30, 2023

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/5125585359
✅ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/5125585359
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/source.py        31      0   100%
source_instagram/__init__.py       2      0   100%
source_instagram/common.py        36      1    97%
source_instagram/streams.py      218     14    94%
source_instagram/api.py           61      9    85%
--------------------------------------------------
TOTAL                            348     24    93%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/__init__.py       2      0   100%
source_instagram/api.py           61      7    89%
source_instagram/source.py        31     11    65%
source_instagram/streams.py      218    102    53%
source_instagram/common.py        36     22    39%
--------------------------------------------------
TOTAL                            348    142    59%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:212: Skipping new incremental test based on acceptance-test-config.yml
================== 37 passed, 3 skipped in 198.15s (0:03:18) ===================

@artem1205 artem1205 merged commit df71aba into master May 30, 2023
25 of 27 checks passed
@artem1205 artem1205 deleted the artem1205/source-instagram-GraphMethodException-100 branch May 30, 2023 19:56
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* Source Instagram: handle permission error

* Source Instagram: update docs

* Source Instagram: reduce max_retry -> 5; remove retry for 2108006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/instagram
Projects
None yet
4 participants