Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Instagram: handle permission error #26767

Merged
merged 3 commits into from
May 30, 2023
Merged

Source Instagram: handle permission error #26767

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb2e041
Source Instagram: handle permission error
artem1205 May 30, 2023
620c42b
Source Instagram: update docs
artem1205 May 30, 2023
a5255d5
Source Instagram: reduce max_retry -> 5; remove retry for 2108006
artem1205 May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-instagram/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=1.0.7
LABEL io.airbyte.version=1.0.8
LABEL io.airbyte.name=airbyte/source-instagram
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-instagram/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 6acf6b55-4f1e-4fca-944e-1a3caef8aba8
dockerImageTag: 1.0.7
dockerImageTag: 1.0.8
dockerRepository: airbyte/source-instagram
githubIssueLabel: source-instagram
icon: instagram.svg
Expand Down
3 changes: 3 additions & 0 deletions airbyte-integrations/connectors/source-instagram/source_instagram/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,9 @@ def _get_insights(self, item, account_id) -> Optional[MutableMapping[str, Any]]:
# We receive all Media starting from the last one, and if on the next Media we get an Insight error,
# then no reason to make inquiries for each Media further, since they were published even earlier.
return None
elif error.api_error_code() == 100 and error.api_error_subcode() == 33:
self.logger.error(f"Check provided permissions for {account_id}: {error.api_error_message()}")
return None
raise error


Expand Down
31 changes: 24 additions & 7 deletions airbyte-integrations/connectors/source-instagram/unit_tests/test_streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,9 @@ def test_media_insights_read(api, user_stories_data, user_media_insights_data, r
def test_media_insights_read_error(api, requests_mock):
test_id = "test_id"
stream = MediaInsights(api=api)
media_response = [{"id": "test_id"}, {"id": "test_id_2"}, {"id": "test_id_3"}]
media_response = [{"id": "test_id"}, {"id": "test_id_2"}, {"id": "test_id_3"}, {"id": "test_id_4"}]
requests_mock.register_uri("GET", FacebookSession.GRAPH + f"/{FB_API_VERSION}/{test_id}/media", json={"data": media_response})

media_insights_response_test_id = {
"name": "impressions",
"period": "lifetime",
Expand All @@ -86,7 +87,8 @@ def test_media_insights_read_error(api, requests_mock):
"id": "test_id/insights/impressions/lifetime",
}
requests_mock.register_uri("GET", FacebookSession.GRAPH + f"/{FB_API_VERSION}/{test_id}/insights", json=media_insights_response_test_id)
error_response = {

error_response_oauth = {
"error": {
"message": "Invalid parameter",
"type": "OAuthException",
Expand All @@ -96,27 +98,42 @@ def test_media_insights_read_error(api, requests_mock):
"is_transient": False,
"error_user_title": "Media posted before business account conversion",
"error_user_msg": "The media was posted before the most recent time that the user's account was converted to a business account from a personal account.",
"fbtrace_id": "AJiAbw1WoyMzMUhBTxJqpxO"
"fbtrace_id": "fake_trace_id"
}
}
requests_mock.register_uri("GET", FacebookSession.GRAPH + f"/{FB_API_VERSION}/test_id_2/insights", json=error_response_oauth, status_code=400)

error_response_wrong_permissions = {
"error": {
"message": "Invalid parameter",
"type": "OAuthException",
"code": 100,
"error_data": {},
"error_subcode": 33,
"is_transient": False,
"error_user_msg": "Unsupported get request. Object with ID 'test_id_3' does not exist, cannot be loaded due to missing permissions, or does not support this operation.",
"fbtrace_id": "fake_trace_id"
}
}
requests_mock.register_uri("GET", FacebookSession.GRAPH + f"/{FB_API_VERSION}/test_id_2/insights", json=error_response, status_code=400)
media_insights_response_test_id_3 = {
requests_mock.register_uri("GET", FacebookSession.GRAPH + f"/{FB_API_VERSION}/test_id_3/insights", json=error_response_wrong_permissions, status_code=400)

media_insights_response_test_id_4 = {
"name": "impressions",
"period": "lifetime",
"values": [{"value": 300}],
"title": "Impressions",
"description": "Total number of times the media object has been seen",
"id": "test_id_3/insights/impressions/lifetime",
}
requests_mock.register_uri("GET", FacebookSession.GRAPH + f"/{FB_API_VERSION}/test_id_3/insights", json=media_insights_response_test_id_3)
requests_mock.register_uri("GET", FacebookSession.GRAPH + f"/{FB_API_VERSION}/test_id_4/insights", json=media_insights_response_test_id_4)

records = read_full_refresh(stream)
expected_records = [{"business_account_id": "test_id",
"id": "test_id",
"impressions": 264,
"page_id": "act_unknown_account"},
{"business_account_id": "test_id",
"id": "test_id_3",
"id": "test_id_4",
"impressions": 300,
"page_id": "act_unknown_account"}]
assert records == expected_records
Expand Down
5 changes: 3 additions & 2 deletions docs/integrations/sources/instagram.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ Instagram limits the number of requests that can be made at a time, but the Inst
AirbyteRecords are required to conform to the [Airbyte type](https://docs.airbyte.com/understanding-airbyte/supported-data-types/) system. This means that all sources must produce schemas and records within these types and all destinations must handle records that conform to this type system.

| Integration Type | Airbyte Type |
| :--------------- | :----------- |
|:-----------------|:-------------|
| `string` | `string` |
| `number` | `number` |
| `array` | `array` |
Expand All @@ -82,8 +82,9 @@ AirbyteRecords are required to conform to the [Airbyte type](https://docs.airbyt

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:----------------------------------------------------------------------------------------------------------------|
| 1.0.8 | 2023-05-26 | [26767](https://github.com/airbytehq/airbyte/pull/26767) | Handle permission error for insights |
| 1.0.7 | 2023-05-26 | [26656](https://github.com/airbytehq/airbyte/pull/26656) | Remove authSpecification from connector specification in favour of advancedAuth |
| 1.0.6 | 2023-03-28 | [26599](https://github.com/airbytehq/airbyte/pull/26599) | Media posted before business account conversion |
| 1.0.6 | 2023-03-28 | [26599](https://github.com/airbytehq/airbyte/pull/26599) | Handle error for Media posted before business account conversion |
| 1.0.5 | 2023-03-28 | [24634](https://github.com/airbytehq/airbyte/pull/24634) | Add user-friendly message for no instagram_business_accounts case |
| 1.0.4 | 2023-03-15 | [23671](https://github.com/airbytehq/airbyte/pull/23671) | Add info about main permissions in spec and doc links in error message to navigate user |
| 1.0.3 | 2023-03-14 | [24043](https://github.com/airbytehq/airbyte/pull/24043) | Do not emit incomplete records for `user_insights` stream |
Expand Down
Loading