Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-faker: cursor = updated_at & remove records_per_sync #27684

Merged
merged 9 commits into from Jun 24, 2023

Conversation

evantahler
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 24, 2023
@evantahler evantahler marked this pull request as ready for review June 24, 2023 00:05
@evantahler evantahler changed the title source-faker: cursor = updated_at & remove records_per_sync source-faker: cursor = updated_at & remove records_per_sync Jun 24, 2023
@evantahler evantahler requested a review from edgao June 24, 2023 00:05
@octavia-squidington-iii
Copy link
Collaborator

source-faker test report (commit 9d938ad61b) - ❌

⏲️ Total pipeline duration: 40 seconds

Step Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-faker docker image for platform linux/x86_64
Unit tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! doublechecking my understanding:

  • if an incremental sync succeeds, the next sync will reemit the entire set of the same users
  • but if an incremental sync crashes, the next sync will pick up at the previous state message

?

@octavia-squidington-iii
Copy link
Collaborator

source-faker test report (commit 9d938ad61b) - ❌

⏲️ Total pipeline duration: 55 seconds

Step Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-faker docker image for platform linux/x86_64
Unit tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

@evantahler
Copy link
Contributor Author

thanks! doublechecking my understanding:

  • if an incremental sync succeeds, the next sync will reemit the entire set of the same users
  • but if an incremental sync crashes, the next sync will pick up at the previous state message

?

Exactly!

@octavia-squidington-iii
Copy link
Collaborator

source-faker test report (commit 29852f6343) - ❌

⏲️ Total pipeline duration: 31 seconds

Step Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-faker docker image for platform linux/x86_64
Unit tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

@evantahler evantahler enabled auto-merge (squash) June 24, 2023 00:15
@octavia-squidington-iii
Copy link
Collaborator

source-faker test report (commit 45d840e0d1) - ❌

⏲️ Total pipeline duration: 1314 seconds

Step Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-faker docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

@octavia-squidington-iii
Copy link
Collaborator

source-faker test report (commit f40fbf170e) - ❌

⏲️ Total pipeline duration: 1294 seconds

Step Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-faker docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

@octavia-squidington-iii
Copy link
Collaborator

source-faker test report (commit b50113ddc7) - ❌

⏲️ Total pipeline duration: 1327 seconds

Step Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-faker docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

@octavia-squidington-iii
Copy link
Collaborator

source-faker test report (commit 3a53311823) - ❌

⏲️ Total pipeline duration: 130 seconds

Step Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-faker docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

@octavia-squidington-iii
Copy link
Collaborator

source-faker test report (commit 3bf10685ff) - ❌

⏲️ Total pipeline duration: 100 seconds

Step Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-faker docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

@octavia-squidington-iii
Copy link
Collaborator

source-faker test report (commit 46b93997f1) - ✅

⏲️ Total pipeline duration: 101 seconds

Step Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-faker docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

@evantahler evantahler merged commit 94097d0 into master Jun 24, 2023
21 checks passed
@evantahler evantahler deleted the evan/faker-updated-at-cursor branch June 24, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/faker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants