Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify faker offsets and limits #27807

Merged
merged 3 commits into from Jun 28, 2023
Merged

Simplify faker offsets and limits #27807

merged 3 commits into from Jun 28, 2023

Conversation

evantahler
Copy link
Contributor

@evantahler evantahler commented Jun 28, 2023

Fixes a bug introduced in #27684 in which products could have a null updated_at. This PR also greatly simplifies the generation limits for each stream.

Closes #27802

@evantahler evantahler marked this pull request as ready for review June 28, 2023 19:08
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/faker labels Jun 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii
Copy link
Collaborator

source-faker test report (commit fcf3f163a3) - ✅

⏲️ Total pipeline duration: 146 seconds

Step Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-faker docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

@octavia-squidington-iii
Copy link
Collaborator

source-faker test report (commit fcf3f163a3) - ✅

⏲️ Total pipeline duration: 131 seconds

Step Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-faker docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

Comment on lines +60 to +61
updated_at = format_airbyte_time(datetime.datetime.now())
product["updated_at"] = updated_at
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the explicit fix - updated_at is always set to a value now

@evantahler evantahler requested review from bnchrch and edgao June 28, 2023 19:31
Copy link
Contributor

@bnchrch bnchrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

I will be honest, there is a lot in this connector thats hard to follow.

But its a connector for testing not for users 😛

@evantahler
Copy link
Contributor Author

It's the multi threading... and it was my first-ever Python project 😅

It's probably due for a refactor!

@evantahler evantahler merged commit 788a0ec into master Jun 28, 2023
25 checks passed
@evantahler evantahler deleted the evan/faker-update_at-fix branch June 28, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/faker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

source-faker crash
3 participants