Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Sheets Destination connector licenses to Elv2 #27780

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

evantahler
Copy link
Contributor

See #27724

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jun 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@evantahler evantahler marked this pull request as ready for review June 27, 2023 21:08
@evantahler evantahler enabled auto-merge (squash) June 27, 2023 21:08
@octavia-squidington-iii
Copy link
Collaborator

destination-google-sheets test report (commit f3ee83e7ab) - ❌

⏲️ Total pipeline duration: 187 seconds

Step Result
Validate airbyte-integrations/connectors/destination-google-sheets/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build destination-google-sheets docker image for platform linux/x86_64
Unit tests
Integration tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-google-sheets test

@octavia-squidington-iii
Copy link
Collaborator

destination-google-sheets test report (commit ffb8b76f1f) - ❌

⏲️ Total pipeline duration: 127 seconds

Step Result
Validate airbyte-integrations/connectors/destination-google-sheets/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build destination-google-sheets docker image for platform linux/x86_64
Unit tests
Integration tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-google-sheets test

@evantahler
Copy link
Contributor Author

I can't see the QA check failure on CI, but locally:

 process "run-qa-checks connectors/destination-google-sheets" did not complete successfully: exit code: 1                                                                                                                                 │ │
│ │ Stdout:                                                                                                                                                                                                                                  │ │
│ │ Running QA checks for destination-google-sheets:0.2.0                                                                                                                                                                                    │ │
│ │ The following files have http:// URLs:                                                                                                                                                                                                   │ │
│ │         - airbyte-integrations/connectors/destination-google-sheets/destination_google_sheets/helpers.py                                                                                                                                 │ │
│ │ QA checks failed for destination-google-sheets:0.2.0:                                                                                                                                                                                    │ │
│ │ ✅ - check_documentation_file_exists                                                                                                                                                                                                     │ │
│ │ ✅ - check_migration_guide                                                                                                                                                                                                               │ │
│ │ ✅ - check_changelog_entry_is_updated                                                                                                                                                                                                    │ │
│ │ ✅ - check_connector_icon_is_available                                                                                                                                                                                                   │ │
│ │ ❌ - check_connector_https_url_only                                                                                                                                                                                                      │ │
│ │ ✅ - check_connector_has_no_critical_vulnerabilities                                                                                                                                                                                     │ │
│ │ ✅ - check_metadata_version_matches_dockerfile_label                                                                                                                                                                                     │ │
│ │ Stderr:

This is an Alpha destination, and this same test is failing on master

@evantahler
Copy link
Contributor Author

/approve-and-merge reason="connector licenses to Elv2 - google sheets tests are already failing on master"

@octavia-approvington
Copy link
Contributor

Enough! Let's do this
goooooo!

@octavia-approvington octavia-approvington merged commit fd34fe3 into master Jun 27, 2023
@octavia-approvington octavia-approvington deleted the evan/elv2-google-sheets-destination branch June 27, 2023 21:31
@evantahler
Copy link
Contributor Author

Problem addressed in #27782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/google-sheets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants