Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source delighted: change 'date since' title to 'replication start date' #27946

Merged
merged 6 commits into from
Sep 8, 2023

Conversation

ChristoGrab
Copy link
Contributor

What

  • Changed "Date Since" title to "Replication Start Date".

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii
Copy link
Collaborator

source-delighted test report (commit a7f491c3d6) - ❌

⏲️ Total pipeline duration: 06mn48s

Step Result
Validate airbyte-integrations/connectors/source-delighted/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-delighted docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-delighted test

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jul 5, 2023
@octavia-squidington-iii
Copy link
Collaborator

source-delighted test report (commit cbc885e5bf) - ❌

⏲️ Total pipeline duration: 06mn08s

Step Result
Validate airbyte-integrations/connectors/source-delighted/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-delighted docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-delighted test

@octavia-squidington-iii
Copy link
Collaborator

source-delighted test report (commit cbc885e5bf) - ❌

⏲️ Total pipeline duration: 05mn43s

Step Result
Validate airbyte-integrations/connectors/source-delighted/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-delighted docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-delighted test

Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristoGrab sweet, thanks for making the change!

once this PR is merged, the failure you are encountering should resolve itself and you should merge this

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

source-delighted test report (commit 225de027b4) - ✅

⏲️ Total pipeline duration: 03mn50s

Step Result
Connector package install
Build source-delighted docker image for platform linux/x86_64
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-delighted/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-delighted test

@ChristoGrab ChristoGrab merged commit 7dc0f6f into master Sep 8, 2023
23 checks passed
@ChristoGrab ChristoGrab deleted the ChristoGrab-delighted-title-change branch September 8, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/delighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants