Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Google Ads: update input field tooltips #28832

Merged
merged 8 commits into from Jul 31, 2023

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Jul 28, 2023

What

Made some small updates to the tooltip descriptions for Google Ads

How

  • Removed comment in customer_id field about not being able to request metrics streams for Manager accounts as it doesn't seem pertinent to explaining the field's value
  • Added a pattern descriptor for login_customer_id field
  • Noted that conversion_window uses days as the time unit
  • Minor edits and typo fixes

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jul 28, 2023
@ChristoGrab ChristoGrab changed the title Source Google Ads: update input tooltips Source Google Ads: update input field tooltips Jul 28, 2023
@ChristoGrab ChristoGrab marked this pull request as ready for review July 28, 2023 18:13
@octavia-squidington-iii
Copy link
Collaborator

source-google-ads test report (commit 2a2daacea0) - ✅

⏲️ Total pipeline duration: 27mn44s

Step Result
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-google-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

ChristoGrab and others added 3 commits July 31, 2023 13:03
…e_ads/spec.json

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
…e_ads/spec.json

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
@octavia-squidington-iii
Copy link
Collaborator

source-google-ads test report (commit 4d394e599e) - ✅

⏲️ Total pipeline duration: 18mn49s

Step Result
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-google-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

@octavia-squidington-iii
Copy link
Collaborator

source-google-ads test report (commit 3fdf2a7be0) - ❌

⏲️ Total pipeline duration: 25mn06s

Step Result
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-google-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

@octavia-squidington-iii
Copy link
Collaborator

source-google-ads test report (commit dbc169dfa2) - ✅

⏲️ Total pipeline duration: 22mn52s

Step Result
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-google-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

@ChristoGrab ChristoGrab merged commit 0513b1c into master Jul 31, 2023
22 checks passed
@ChristoGrab ChristoGrab deleted the google-ads-spec-update branch July 31, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants