Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Google Ads: update input field tooltips #28832

Merged
merged 8 commits into from Jul 31, 2023
Merged

Source Google Ads: update input field tooltips #28832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
35822ed
update field descriptions
ChristoGrab Jul 28, 2023
ab500f4
version bump
ChristoGrab Jul 28, 2023
3bd1684
changelog update
ChristoGrab Jul 28, 2023
2a2daac
add missing cell in table
ChristoGrab Jul 28, 2023
a81885e
Update airbyte-integrations/connectors/source-google-ads/source_googl…
ChristoGrab Jul 31, 2023
4d394e5
Update airbyte-integrations/connectors/source-google-ads/source_googl…
ChristoGrab Jul 31, 2023
3fdf2a7
Merge branch 'master' into google-ads-spec-update
ChristoGrab Jul 31, 2023
dbc169d
Merge branch 'master' into google-ads-spec-update
ChristoGrab Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-google-ads/Dockerfile
View file
Open in desktop
Expand Up @@ -13,5 +13,5 @@ COPY main.py ./

ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.7.3
LABEL io.airbyte.version=0.7.4
LABEL io.airbyte.name=airbyte/source-google-ads
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-google-ads/metadata.yaml
View file
Open in desktop
Expand Up @@ -6,7 +6,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 253487c0-2246-43ba-a21f-5116b20a2c50
dockerImageTag: 0.7.3
dockerImageTag: 0.7.4
dockerRepository: airbyte/source-google-ads
githubIssueLabel: source-google-ads
icon: google-adwords.svg
Expand Down
25 changes: 13 additions & 12 deletions airbyte-integrations/connectors/source-google-ads/source_google_ads/spec.json
View file
Open in desktop
Expand Up @@ -23,42 +23,42 @@
"type": "string",
"title": "Developer Token",
"order": 0,
"description": "Developer token granted by Google to use their APIs. More instruction on how to find this value in our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">docs</a>",
"description": "The Developer Token granted by Google to use their APIs. For detailed instructions on finding this value, refer to our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">documentation</a>.",
"airbyte_secret": true
},
"client_id": {
"type": "string",
"title": "Client ID",
"order": 1,
"description": "The Client ID of your Google Ads developer application. More instruction on how to find this value in our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">docs</a>"
"description": "The Client ID of your Google Ads developer application. For detailed instructions on finding this value, refer to our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">documentation</a>."
},
"client_secret": {
"type": "string",
"title": "Client Secret",
"order": 2,
"description": "The Client Secret of your Google Ads developer application. More instruction on how to find this value in our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">docs</a>",
"description": "The Client Secret of your Google Ads developer application. For detailed instructions on finding this value, refer to our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">documentation</a>.",
"airbyte_secret": true
},
"refresh_token": {
"type": "string",
"title": "Refresh Token",
"order": 3,
"description": "The token for obtaining a new access token. More instruction on how to find this value in our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">docs</a>",
"description": "The token used to obtain a new Access Token. For detailed instructions on finding this value, refer to our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">documentation</a>.",
"airbyte_secret": true
},
"access_token": {
"type": "string",
"title": "Access Token",
"order": 4,
"description": "Access Token for making authenticated requests. More instruction on how to find this value in our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">docs</a>",
"description": "The Access Token for making authenticated requests. For detailed instructions on finding this value, refer to our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">documentation</a>.",
"airbyte_secret": true
}
}
},
"customer_id": {
"title": "Customer ID(s)",
"type": "string",
"description": "Comma separated list of (client) customer IDs. Each customer ID must be specified as a 10-digit number without dashes. More instruction on how to find this value in our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">docs</a>. Metrics streams like AdGroupAdReport cannot be requested for a manager account.",
"description": "Comma-separated list of (client) customer IDs. Each customer ID must be specified as a 10-digit number without dashes. For detailed instructions on finding this value, refer to our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">documentation</a>.",
"pattern": "^[0-9]{10}(,[0-9]{10})*$",
"pattern_descriptor": "The customer ID must be 10 digits. Separate multiple customer IDs using commas.",
"examples": ["6783948572,5839201945"],
Expand All @@ -67,7 +67,7 @@
"start_date": {
"type": "string",
"title": "Start Date",
"description": "UTC date and time in the format 2017-01-25. Any data before this date will not be replicated.",
"description": "UTC date in the format YYYY-MM-DD. Any data before this date will not be replicated.",
"pattern": "^[0-9]{4}-[0-9]{2}-[0-9]{2}$",
"pattern_descriptor": "YYYY-MM-DD",
"examples": ["2017-01-25"],
Expand All @@ -77,7 +77,7 @@
"end_date": {
"type": "string",
"title": "End Date",
"description": "UTC date and time in the format 2017-01-25. Any data after this date will not be replicated.",
"description": "UTC date in the format YYYY-MM-DD. Any data after this date will not be replicated.",
"pattern": "^$|^[0-9]{4}-[0-9]{2}-[0-9]{2}$",
"pattern_descriptor": "YYYY-MM-DD",
"examples": ["2017-01-30"],
Expand All @@ -97,31 +97,32 @@
"type": "string",
"multiline": true,
"title": "Custom Query",
"description": "A custom defined GAQL query for building the report. Should not contain segments.date expression because it is used by incremental streams. See Google's <a href=\"https://developers.google.com/google-ads/api/fields/v11/overview_query_builder\">query builder</a> for more information.",
"description": "A custom defined GAQL query for building the report. Avoid including the segments.date field; wherever possible, Airbyte will automatically include it for incremental syncs. For more information, refer to <a href=\"https://developers.google.com/google-ads/api/fields/v11/overview_query_builder\">Google's documentation</a>.",
"examples": [
"SELECT segments.ad_destination_type, campaign.advertising_channel_sub_type FROM campaign WHERE campaign.status = 'PAUSED'"
]
},
"table_name": {
"type": "string",
"title": "Destination Table Name",
"description": "The table name in your destination database for choosen query."
"description": "The table name in your destination database for the chosen query."
}
}
}
},
"login_customer_id": {
"type": "string",
"title": "Login Customer ID for Managed Accounts",
"description": "If your access to the customer account is through a manager account, this field is required and must be set to the customer ID of the manager account (10-digit number without dashes). More information about this field you can see <a href=\"https://developers.google.com/google-ads/api/docs/concepts/call-structure#cid\">here</a>",
"description": "If your access to the customer account is through a manager account, this field is required, and must be set to the 10-digit customer ID of the manager account. For more information about this field, refer to <a href=\"https://developers.google.com/google-ads/api/docs/concepts/call-structure#cid\">Google's documentation</a>.",
"pattern_descriptor": ": 10 digits, with no dashes.",
"pattern": "^([0-9]{10})?$",
"examples": ["7349206847"],
"order": 4
},
"conversion_window_days": {
"title": "Conversion Window",
"type": "integer",
"description": "A conversion window is the period of time after an ad interaction (such as an ad click or video view) during which a conversion, such as a purchase, is recorded in Google Ads. For more information, see Google's <a href=\"https://support.google.com/google-ads/answer/3123169?hl=en\">documentation</a>.",
"description": "A conversion window is the number of days after an ad interaction (such as an ad click or video view) during which a conversion, such as a purchase, is recorded in Google Ads. For more information, see <a href=\"https://support.google.com/google-ads/answer/3123169?hl=en\">Google's documentation</a>.",
"minimum": 0,
"maximum": 1095,
"default": 14,
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/google-ads.md
View file
Open in desktop
Expand Up @@ -167,6 +167,7 @@ Due to a limitation in the Google Ads API which does not allow getting performan

| Version | Date | Pull Request | Subject |
|:---------|:-----------|:---------------------------------------------------------|:-------------------------------------------------------------------------------------------------------------------------------------|
| `0.7.4` | 2023-07-28 | [28832](https://github.com/airbytehq/airbyte/pull/28832) | Update field descriptions |
| `0.7.3` | 2023-07-24 | [28510](https://github.com/airbytehq/airbyte/pull/28510) | Set dates with client's timezone |
| `0.7.2` | 2023-07-20 | [28535](https://github.com/airbytehq/airbyte/pull/28535) | UI improvement: Make the query field in custom reports a multi-line string field |
| `0.7.1` | 2023-07-17 | [28365](https://github.com/airbytehq/airbyte/pull/28365) | 0.3.1 and 0.3.2 follow up: make today the end date, not yesterday |
Expand Down