Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Source Plaid: Migrate Python CDK to No-code CDK #29127

Merged
merged 40 commits into from Aug 17, 2023
Merged

✨Source Plaid: Migrate Python CDK to No-code CDK #29127

merged 40 commits into from Aug 17, 2023

Conversation

masyagin1998
Copy link
Contributor

@masyagin1998 masyagin1998 commented Aug 6, 2023 •
edited

What

How

  • created Plaid no-code version in Airbyte Connector Builder and then put it to new source

Recommended reading order

  • manifest.yaml

🚨 User Impact 🚨

  • no

Pre-merge Actions

  • review

@masyagin1998
airbyte: add no-code plaid connector
7a59078 
* add no-code version of Plaid connector with 2 current problems:
* for now airbyte response filter can't stop stream without an error
* for now airbyte incremental sync without specifiying dates doesn't filter records
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@masyagin1998 masyagin1998 mentioned this pull request Aug 6, 2023
Closed
@masyagin1998 masyagin1998 changed the title airbyte: add no-code plaid connector New Source: Plaid no-code Aug 6, 2023
@masyagin1998 masyagin1998 changed the title New Source: Plaid no-code Source Plaid: Migrate Python CDK to No-code CDK Aug 6, 2023
@masyagin1998
Copy link
Contributor Author

I think, I can add support of translations stream without any changes to low-code SDK if I use /transactions/get instead of /transactions/sync, but I'm not sure if it's okay.

Also the bug is still present: records in single response are not filtered by date

@masyagin1998
airbyte: add support of /transactions/get api
c2d2f6b
@masyagin1998
airbyte: add airbyte_secret to access_token
9c5935a 
* add airbyte_secret to access_token, because without it acceptance_test fails
@masyagin1998
Copy link
Contributor Author

masyagin1998 commented Aug 7, 2023 •
edited

Now all streams are working and acceptance_test succeeds!
I decided not to remove transaction stream with potential bug to show its problems.

@masyagin1998 masyagin1998 changed the title Source Plaid: Migrate Python CDK to No-code CDK sparkles Source Plaid: Migrate Python CDK to No-code CDK Aug 7, 2023
@masyagin1998 masyagin1998 changed the title sparkles Source Plaid: Migrate Python CDK to No-code CDK Source Plaid: Migrate Python CDK to No-code CDK Aug 7, 2023
@marcosmarxm marcosmarxm added the team/tse Technical Support Engineers label Aug 8, 2023
@RealChrisSean RealChrisSean added Hackathon External low-code/ui connector builder hackathons ui/connector-builder labels Aug 8, 2023
@octavia-squidington-iii octavia-squidington-iii added area/documentation Improvements or additions to documentation connectors/source/plaid labels Aug 9, 2023
@masyagin1998
Copy link
Contributor Author

Screenshot from 2023-08-11 23-53-51
Hey @marcosmarxm , done!

@masyagin1998
Copy link
Contributor Author

@marcosmarxm added results to all my other connectors too)

@sh4sh sh4sh mentioned this pull request Aug 17, 2023
Closed
@masyagin1998 masyagin1998 changed the title Source Plaid: Migrate Python CDK to No-code CDK ✨Source Plaid: Migrate Python CDK to No-code CDK Aug 17, 2023
@masyagin1998
Copy link
Contributor Author

Hey @sajarin and @sh4sh !
Do you know how can I fight this error: echo "PR is from a fork. Exiting workflow..." ?
Many thanks for your reviews and fixes!!!

@sajarin
Copy link
Contributor

sajarin commented Aug 17, 2023

Hey @sajarin and @sh4sh ! Do you know how can I fight this error: echo "PR is from a fork. Exiting workflow..." ? Many thanks for your reviews and fixes!!!

hey @masyagin1998 due to security reasons with our integration secrets, CI jobs need to ran on a branch with master access, so the error you mentioned will always appear on your PRs since you're not a member of the airbyte organization. We will run tests in a different PR and merge this one, once the tests are passing!

@masyagin1998
Copy link
Contributor Author

masyagin1998 commented Aug 17, 2023 •
edited

@sajarin thank you for answer!
I know the solution: I have to work at Airbyte :D

@sh4sh sh4sh mentioned this pull request Aug 17, 2023
Closed
@sh4sh sh4sh merged commit cc43bd7 into airbytehq:master Aug 17, 2023
35 of 37 checks passed
@sh4sh
Copy link
Contributor

sh4sh commented Aug 17, 2023

Thanks for your contribution!

harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
@masyagin1998 @sajarin
@sh4sh @harrytou
✨Source Plaid: Migrate Python CDK to No-code CDK (airbytehq#29127)
6f884b5 
Co-authored-by: Sajarin <sajarindider@gmail.com>
Co-authored-by: sh4sh <6833405+sh4sh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh4sh sh4sh sh4sh approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/plaid connectors/source/plaid-no-code Hackathon External low-code/ui connector builder hackathons hackathon-2023-08 team/tse Technical Support Engineers
Projects
Community Contributed PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plaid
6 participants
@masyagin1998 @marcosmarxm @sajarin @sh4sh @RealChrisSean @octavia-squidington-iii