Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for #29127 #29518

Closed
wants to merge 36 commits into from
Closed

CI for #29127 #29518

wants to merge 36 commits into from

Conversation

sh4sh
Copy link
Contributor

@sh4sh sh4sh commented Aug 17, 2023

Running checks for community pr #29127

masyagin1998 and others added 30 commits August 6, 2023 18:12
* add no-code version of Plaid connector with 2 current problems:
* for now airbyte response filter can't stop stream without an error
* for now airbyte incremental sync without specifiying dates doesn't filter records
* add airbyte_secret to access_token, because without it acceptance_test fails
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/plaid labels Aug 17, 2023
@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii
Copy link
Collaborator

source-plaid test report (commit 83a4a2467f) - ❌

⏲️ Total pipeline duration: 02mn01s

Step Result
Validate airbyte-integrations/connectors/source-plaid/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-plaid docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-plaid test

@octavia-squidington-iii
Copy link
Collaborator

source-plaid test report (commit 83a4a2467f) - ❌

⏲️ Total pipeline duration: 01mn11s

Step Result
Validate airbyte-integrations/connectors/source-plaid/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-plaid docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-plaid test

@octavia-squidington-iii
Copy link
Collaborator

source-plaid test report (commit 171014e29d) - ❌

⏲️ Total pipeline duration: 01mn17s

Step Result
Validate airbyte-integrations/connectors/source-plaid/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-plaid docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-plaid test

@octavia-squidington-iii
Copy link
Collaborator

source-plaid test report (commit 171014e29d) - ❌

⏲️ Total pipeline duration: 51.00s

Step Result
Validate airbyte-integrations/connectors/source-plaid/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-plaid docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-plaid test

@sh4sh sh4sh closed this Aug 17, 2023
@sh4sh sh4sh deleted the plaid-no-code-connector branch August 17, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/plaid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants