✨ Source LinkedIn Ads: Add new analytics streams #29175

artem1205 · 2023-08-07T18:04:31Z

What

Resolve
#26934

How

add new streams:

AdImpressionDeviceAnalytics
AdMemberCompanySizeAnalytics
AdMemberCountryAnalytics
AdMemberJobFunctionAnalytics
AdMemberJobTitleAnalytics,
AdMemberIndustryAnalytics
AdMemberSeniorityAnalytics
AdMemberRegionAnalytics
AdMemberCompanyAnalytics

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

github-actions · 2023-08-07T18:04:52Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

…nkedin-ads-analytics-stream

octavia-squidington-iii · 2023-08-08T13:51:58Z

source-linkedin-ads test report (commit `c316c987be`) - ❌

⏲️ Total pipeline duration: 12mn32s

Step	Result
Validate airbyte-integrations/connectors/source-linkedin-ads/metadata.yaml	✅
Connector version semver check	❌
Connector version increment check	❌
QA checks	✅
Code format checks	❌
Connector package install	✅
Build source-linkedin-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-linkedin-ads test

octavia-squidington-iii · 2023-08-08T15:45:55Z

source-linkedin-ads test report (commit `80b07ec5c1`) - ❌

⏲️ Total pipeline duration: 93mn09s

Step	Result
Validate airbyte-integrations/connectors/source-linkedin-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	❌
Connector package install	✅
Build source-linkedin-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-linkedin-ads test

octavia-squidington-iii · 2023-08-08T17:43:00Z

source-linkedin-ads test report (commit `5c3347b3c9`) - ❌

⏲️ Total pipeline duration: 88mn35s

Step	Result
Validate airbyte-integrations/connectors/source-linkedin-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-linkedin-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-linkedin-ads test

…tal timeout

octavia-squidington-iii · 2023-08-08T21:13:14Z

source-linkedin-ads test report (commit `b91b9bccff`) - ❌

⏲️ Total pipeline duration: 107mn11s

Step	Result
Validate airbyte-integrations/connectors/source-linkedin-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-linkedin-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-linkedin-ads test

octavia-squidington-iii · 2023-08-09T10:55:49Z

source-linkedin-ads test report (commit `20465e93df`) - ❌

⏲️ Total pipeline duration: 30mn21s

Step	Result
Validate airbyte-integrations/connectors/source-linkedin-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-linkedin-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-linkedin-ads test

octavia-squidington-iii · 2023-08-09T12:36:51Z

source-linkedin-ads test report (commit `8fe17dd453`) - ❌

⏲️ Total pipeline duration: 31mn42s

Step	Result
Validate airbyte-integrations/connectors/source-linkedin-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-linkedin-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-linkedin-ads test

octavia-squidington-iii · 2023-08-09T13:23:12Z

source-linkedin-ads test report (commit `34666579fe`) - ✅

⏲️ Total pipeline duration: 30mn17s

Step	Result
Validate airbyte-integrations/connectors/source-linkedin-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-linkedin-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-linkedin-ads test

bazarnov

LGTM!

* Source LinkedIn Ads: add analytics streams * Source LinkedIn Ads: update expected_records * Source LinkedIn Ads: add future state * Source LinkedIn Ads: update acceptance test config: increase incremental timeout

Escen13 · 2023-09-20T03:06:01Z

#26934
Hi, I have encounter some issues in the ..ad_impression_device_analytics table and hope you may check it out in the following.

I found that the data in _airbyte_raw_ad_impression_device_analytics is not consistent, e.g., some of the objects in the json data is missing. Please refer ss below:

the json data in 1 has 48 objects whereas the data in 2 only has 18 objects, as below:
[1]

[2]

I also noticed that there's an empty value in the device column (i.e., pivotValues), please refer the ss below:

Besides, I'm not sure if the value in the pivotValues object is missing, because I only get one record in one date, if not mistaken I should get 3 row in the same date.. please refer the ss below:
[Query result]

[Linkedin Campaign Manager]

Please look at the record on 5/29/2022, as you can see that I only get 'Mobile Web' on that day but I should get 3 device breakdown, i.e. 'Desktop Web', 'Mobile App', 'Mobile Web', which shown in the Linkedin Campaign Manager. The sum value of the device breakdown (e.g., Mobile Web) shown in the query is correct, the problem is the other device breakdown is missing. Other than that, I'm not sure if you noticed that the query result only show one record per date and If I'm not wrong, I should get 3 row per date.

Much appreciate if you could help identify the exact issue. Look forward to your feedback.

Source LinkedIn Ads: add analytics streams

abe8ef0

octavia-squidington-iii added area/connectors Connector related issues connectors/source/linkedin-ads labels Aug 7, 2023

artem1205 added 4 commits August 7, 2023 22:55

Source LinkedIn Ads: fix empty accounts

c316c98

Source LinkedIn Ads: update expected_records

209c93e

Merge remote-tracking branch 'origin/master' into artem1205/source-li…

f775656

…nkedin-ads-analytics-stream

Source LinkedIn Ads: update docs + bump version

80b07ec

artem1205 changed the title ~~Source LinkedIn Ads: add analytics streams~~ ✨ Source LinkedIn Ads: Add new analytics streams Aug 8, 2023

artem1205 marked this pull request as ready for review August 8, 2023 13:37

artem1205 self-assigned this Aug 8, 2023

artem1205 marked this pull request as draft August 8, 2023 14:04

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 8, 2023

artem1205 marked this pull request as ready for review August 8, 2023 14:11

artem1205 added 2 commits August 8, 2023 17:57

Source LinkedIn Ads: fix formatting

189da93

Source LinkedIn Ads: add future state

5c3347b

Source LinkedIn Ads: update acceptance test config: increase incremen…

b91b9bc

…tal timeout

artem1205 requested review from bazarnov and lazebnyi August 8, 2023 19:37

Source LinkedIn Ads: update acceptance test config

20465e9

Source LinkedIn Ads: update expected records

8fe17dd

Source LinkedIn Ads: update expected records

3466657

bazarnov approved these changes Aug 9, 2023

View reviewed changes

artem1205 merged commit 32091d6 into master Aug 9, 2023
23 checks passed

artem1205 deleted the artem1205/source-linkedin-ads-analytics-stream branch August 9, 2023 20:33

artem1205 linked an issue Aug 9, 2023 that may be closed by this pull request

Source LinkedIn Ads: Is there any way to extract impression_device_type via LinkedIn Ads Marketing API? #26934

Closed

artem1205 mentioned this pull request Aug 9, 2023

Source LinkedIn Ads: Is there any way to extract impression_device_type via LinkedIn Ads Marketing API? #26934

Closed

Escen13 mentioned this pull request Oct 2, 2023

Source LinkedIn Ads: Marketing API: Missing data in new stream AdImpressionDeviceAnalytics #30967

Open

Escen13 mentioned this pull request Dec 8, 2023

Source LinkedIn Ads: Request to add back stream ad_direct_sponsored_contents in the new BigQuery destination connector (v2.0.22) #31121

Open

artem1205 mentioned this pull request Apr 9, 2024

🚨🚨 Source LinkedIn Ads: update primary key for Analytics Streams #36927

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Source LinkedIn Ads: Add new analytics streams #29175

✨ Source LinkedIn Ads: Add new analytics streams #29175

artem1205 commented Aug 7, 2023 •

edited

github-actions bot commented Aug 7, 2023 •

edited by artem1205

octavia-squidington-iii commented Aug 8, 2023

octavia-squidington-iii commented Aug 8, 2023

octavia-squidington-iii commented Aug 8, 2023

octavia-squidington-iii commented Aug 8, 2023

octavia-squidington-iii commented Aug 9, 2023

octavia-squidington-iii commented Aug 9, 2023

octavia-squidington-iii commented Aug 9, 2023

bazarnov left a comment

Escen13 commented Sep 20, 2023

✨ Source LinkedIn Ads: Add new analytics streams #29175

✨ Source LinkedIn Ads: Add new analytics streams #29175

Conversation

artem1205 commented Aug 7, 2023 • edited

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

github-actions bot commented Aug 7, 2023 • edited by artem1205

Before Merging a Connector Pull Request

octavia-squidington-iii commented Aug 8, 2023

source-linkedin-ads test report (commit c316c987be) - ❌

octavia-squidington-iii commented Aug 8, 2023

source-linkedin-ads test report (commit 80b07ec5c1) - ❌

octavia-squidington-iii commented Aug 8, 2023

source-linkedin-ads test report (commit 5c3347b3c9) - ❌

octavia-squidington-iii commented Aug 8, 2023

source-linkedin-ads test report (commit b91b9bccff) - ❌

octavia-squidington-iii commented Aug 9, 2023

source-linkedin-ads test report (commit 20465e93df) - ❌

octavia-squidington-iii commented Aug 9, 2023

source-linkedin-ads test report (commit 8fe17dd453) - ❌

octavia-squidington-iii commented Aug 9, 2023

source-linkedin-ads test report (commit 34666579fe) - ✅

bazarnov left a comment

Choose a reason for hiding this comment

Escen13 commented Sep 20, 2023

artem1205 commented Aug 7, 2023 •

edited

github-actions bot commented Aug 7, 2023 •

edited by artem1205

source-linkedin-ads test report (commit `c316c987be`) - ❌

source-linkedin-ads test report (commit `80b07ec5c1`) - ❌

source-linkedin-ads test report (commit `5c3347b3c9`) - ❌

source-linkedin-ads test report (commit `b91b9bccff`) - ❌

source-linkedin-ads test report (commit `20465e93df`) - ❌

source-linkedin-ads test report (commit `8fe17dd453`) - ❌

source-linkedin-ads test report (commit `34666579fe`) - ✅