Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨🚨 Source LinkedIn Ads: update primary key for Analytics Streams #36927

Merged
merged 13 commits into from
Apr 15, 2024

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Apr 9, 2024

What

Resolve https://github.com/airbytehq/oncall/issues/4863
Resolve https://github.com/airbytehq/oncall/issues/4595

Another bug to be solved:

#29175 (comment)

How

update primary key; remove old properties from schema

[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 4:12pm

@artem1205 artem1205 added the breaking-change Don't merge me unless you are ready. label Apr 9, 2024
@artem1205 artem1205 self-assigned this Apr 9, 2024
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 9, 2024
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 changed the title Source LinkedIn Ads: update a primary key 🚨🚨 Source LinkedIn Ads: update a primary key Apr 9, 2024
@artem1205 artem1205 changed the title 🚨🚨 Source LinkedIn Ads: update a primary key 🚨🚨 Source LinkedIn Ads: update primary key for Analytics Streams Apr 9, 2024
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
breakingChanges:
1.0.0:
message: This upgrade brings changes in primary key to *-analytics streams.
upgradeDeadline: "2024-04-25"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets push this to be April 30

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated


## Upgrading to 1.0.0

Version 1.0.0 introduces changes in primary key for all *-analytics streams (including custom ones).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the stream names here as you did in the metadata file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@octavia-squidington-iv octavia-squidington-iv requested a review from a team April 15, 2024 13:43
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 merged commit da0a7fa into master Apr 15, 2024
29 of 31 checks passed
@artem1205 artem1205 deleted the artem1205/source-linkedin-ads-OC-4863 branch April 15, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation breaking-change Don't merge me unless you are ready. connectors/source/linkedin-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants