Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Fastbill : Migrate Python CDK to Low-code CDK #29390

Closed

Conversation

avirajsingh7
Copy link
Contributor

What

Migrating Source fastbill to Low-Code CDK
Closes #29277

How

Developed using (Configuration Based Source) low-code CDK

Recommended reading order

1 manifest.yaml
2 schemas/*

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?
Yes, there are breaking changes due to Changes to Stream Schema
At many places previous data type were wrong and added some new properties in schema as per response from API

Test

Acceptance Test
Screenshot 2023-08-13 at 2 08 45 AM
Migrate Connector : Source Fastbill
  • Community Member? Grant Edit Access to Maintainers instructions
  • Secrets in the Connector's Spec
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors::integrationTest.
  • Code Reviews Completed
    • Documentation Updated
    • Connector's README.md
    • Connector's bootstrap.md
    • docs/integrations//.md (including changelog. See changelog example)
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR Name follows PR Naming Conventions

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/fastbill labels Aug 13, 2023
@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@marcosmarxm marcosmarxm added team/tse Technical Support Engineers Hackathon External low-code/ui connector builder hackathons hackathon-2023-08 labels Aug 14, 2023
@marcosmarxm
Copy link
Member

Hello 👋 , right now Airbyte's integration tests are failing for this connector and I'm going to work during the week to fix them. Due a high number of contributions we have a backlog and your contribution will be review next week. We ask to you share the integration test from your side whatever possible and if you don't have credentials to run tests to get in touch with @RealChrisSean as soon as possible. Also some common missing steps contributors does migrating to low code are (and you can double check to make sure you implemented this):

  • adding paginator
  • update the documentation changelog + metadata file and dockerfile version
  • if the connector has start_date parameter you must implement incremental syncs

@avirajsingh7
Copy link
Contributor Author

ight now Airbyte's integration tests are failing for this connector and I'm going to work during the week to fix them. Due a high number of contributions we have a backlog and your contribution will be review next week. We ask to you share the integration test from your side whatever possible and if you don't have credentials to run tests to get in touch with @RealChrisSean as soon as possible. Also some common missing steps contributors does migrating to low code are (and you can double check to make sure you implemented this):

  • adding paginator
  • update the documentation changelog + metadata file and dockerfile version
  • if the connector has start_date parameter you must implement increme

Hey @marcosmarxm thanks for confirmation, confused from some days why integration test are failing.
Do let us know how can we help...

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments after we can proceed to merge the contribution

Signed-off-by: Aviraj Gour <100823015+avirajsingh7@users.noreply.github.com>
@avirajsingh7
Copy link
Contributor Author

@marcosmarxm done changes

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

@marcosmarxm
Copy link
Member

Merged in #29767 thanks for the contribution @avirajsingh7

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/fastbill Hackathon External low-code/ui connector builder hackathons hackathon-2023-08 team/tse Technical Support Engineers
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Fastbill
3 participants