-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Source Fastbill : Migrate Python CDK to Low-code CDK #29390
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Hello 👋 , right now Airbyte's integration tests are failing for this connector and I'm going to work during the week to fix them. Due a high number of contributions we have a backlog and your contribution will be review next week. We ask to you share the integration test from your side whatever possible and if you don't have credentials to run tests to get in touch with @RealChrisSean as soon as possible. Also some common missing steps contributors does migrating to low code are (and you can double check to make sure you implemented this):
|
Hey @marcosmarxm thanks for confirmation, confused from some days why integration test are failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments after we can proceed to merge the contribution
airbyte-integrations/connectors/source-fastbill/source_fastbill/manifest.yaml
Show resolved
Hide resolved
airbyte-integrations/connectors/source-fastbill/source_fastbill/manifest.yaml
Show resolved
Hide resolved
Signed-off-by: Aviraj Gour <100823015+avirajsingh7@users.noreply.github.com>
@marcosmarxm done changes |
airbyte-integrations/connectors/source-fastbill/source_fastbill/components.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-fastbill/source_fastbill/components.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments.
airbyte-integrations/connectors/source-fastbill/source_fastbill/components.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-fastbill/source_fastbill/manifest.yaml
Outdated
Show resolved
Hide resolved
Merged in #29767 thanks for the contribution @avirajsingh7 |
What
Migrating Source fastbill to Low-Code CDK
Closes #29277
How
Developed using (Configuration Based Source) low-code CDK
Recommended reading order
1 manifest.yaml
2 schemas/*
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user?
Yes, there are breaking changes due to Changes to Stream Schema
At many places previous data type were wrong and added some new properties in schema as per response from API
Test
Acceptance Test
Migrate Connector : Source Fastbill