Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Public-Api : Migrate Python CDK to Low-code CDK #29391

Closed

Conversation

avirajsingh7
Copy link
Contributor

@avirajsingh7 avirajsingh7 commented Aug 13, 2023

What

Migrating Source public-api to Low-Code CDK
Closes #29454

How

Developed using (Configuration Based Source) low-code CDK

Recommended reading order

  1. spec.yaml
  2. manifest.yaml
  3. schemas/*

🚨 User Impact 🚨

Test

Acceptance Test

There is no authentication still one of the auth test fails

Screenshot 2023-08-13 at 9 06 40 PM
Migrate Connector : Source Public-api
  • Community Member? Grant Edit Access to Maintainers instructions
  • Secrets in the Connector's Spec
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors::integrationTest.
  • Code Reviews Completed
    • Documentation Updated
    • Connector's README.md
    • Connector's bootstrap.md
    • docs/integrations//.md (including changelog. See changelog example)
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR Name follows PR Naming Conventions

@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@avirajsingh7 avirajsingh7 mentioned this pull request Aug 14, 2023
@marcosmarxm marcosmarxm added team/tse Technical Support Engineers Hackathon External low-code/ui connector builder hackathons hackathon-2023-08 labels Aug 14, 2023
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Please update the doc entry too.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 15, 2023
@avirajsingh7
Copy link
Contributor Author

@marcosmarxm Done suggested changes

@RealChrisSean RealChrisSean mentioned this pull request Aug 15, 2023
marcosmarxm added a commit that referenced this pull request Aug 29, 2023
Co-authored-by: Aviraj Gour <asgour2021@gmail.com>
Co-authored-by: Aviraj Gour <100823015+avirajsingh7@users.noreply.github.com>
Co-authored-by: Mal Hancock <mallory@archangelic.space>
@marcosmarxm
Copy link
Member

Published in #29951

harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
… (airbytehq#29951)

Co-authored-by: Aviraj Gour <asgour2021@gmail.com>
Co-authored-by: Aviraj Gour <100823015+avirajsingh7@users.noreply.github.com>
Co-authored-by: Mal Hancock <mallory@archangelic.space>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/public-apis Hackathon External low-code/ui connector builder hackathons hackathon-2023-08 team/tse Technical Support Engineers
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

public api
4 participants