Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source LinkedIn Ads: update field descriptions #29600

Merged
merged 8 commits into from
Aug 24, 2023

Conversation

ChristoGrab
Copy link
Contributor

What

Updated user-facing titles and descriptions in LinkedIn Ads spec file

How

  • Added links to docs where appropriate
  • Minor revisions to descriptions/titles for clarity

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 18, 2023
@ChristoGrab ChristoGrab marked this pull request as ready for review August 18, 2023 19:28
@github-actions
Copy link
Contributor

source-linkedin-ads test report (commit ba37c5605b) - ❌

⏲️ Total pipeline duration: 50.15s

Step Result
Validate airbyte-integrations/connectors/source-linkedin-ads/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-linkedin-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-linkedin-ads test

@github-actions
Copy link
Contributor

source-linkedin-ads test report (commit 565c174289) - ✅

⏲️ Total pipeline duration: 59mn59s

Step Result
Connector package install
Build source-linkedin-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-linkedin-ads/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-linkedin-ads test

@github-actions
Copy link
Contributor

source-linkedin-ads test report (commit a16bba7b12) - ✅

⏲️ Total pipeline duration: 81mn42s

Step Result
Connector package install
Build source-linkedin-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-linkedin-ads/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-linkedin-ads test

Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good additions!

…kedin_ads/spec.json

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
@github-actions
Copy link
Contributor

source-linkedin-ads test report (commit 5e5aec7749) - ❌

⏲️ Total pipeline duration: 15.49s

Step Result

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-linkedin-ads test

@github-actions
Copy link
Contributor

source-linkedin-ads test report (commit a2cfa5c280) - ✅

⏲️ Total pipeline duration: 71mn49s

Step Result
Connector package install
Build source-linkedin-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-linkedin-ads/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-linkedin-ads test

@artem1205 artem1205 merged commit b90e8d6 into master Aug 24, 2023
23 checks passed
@artem1205 artem1205 deleted the christo/linkedin-ads-spec branch August 24, 2023 10:27
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
Co-authored-by: Artem Inzhyyants <36314070+artem1205@users.noreply.github.com>
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/linkedin-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants