-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Amplitude: fix most recent cursor value #30471
Source Amplitude: fix most recent cursor value #30471
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
6a29790
to
bbe4fc1
Compare
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-amplitude docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate airbyte-integrations/connectors/source-amplitude/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-amplitude test
@@ -99,8 +100,16 @@ def _date_time_to_rfc3339(self, record: MutableMapping[str, Any]) -> MutableMapp | |||
record[item] = pendulum.parse(record[item]).to_rfc3339_string() | |||
return record | |||
|
|||
def get_most_recent_cursor(self, stream_state: Mapping[str, Any] = None) -> datetime.datetime: | |||
cursor_date = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add comment how cursor look like for different conditions
What
#25367
How
start_time
instead of cursor in the case of more recentstart_date
to more recent value and updated expected records