Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Amplitude: fix most recent cursor value #30471

Conversation

roman-yermilov-gl
Copy link
Collaborator

@roman-yermilov-gl roman-yermilov-gl commented Sep 15, 2023

What

#25367

How

  • Fix Event stream: use start_time instead of cursor in the case of more recent
  • Shifted start_date to more recent value and updated expected records

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Sep 15, 2023
@roman-yermilov-gl roman-yermilov-gl force-pushed the ryermilov/source-amplitude-fix-most-recent-cursor-value branch from 6a29790 to bbe4fc1 Compare September 15, 2023 11:35
@roman-yermilov-gl roman-yermilov-gl self-assigned this Sep 15, 2023
@roman-yermilov-gl roman-yermilov-gl changed the title Ryermilov/source amplitude fix most recent cursor value Source Amplitude: fix most recent cursor value Sep 15, 2023
@roman-yermilov-gl roman-yermilov-gl marked this pull request as ready for review September 15, 2023 11:53
@github-actions
Copy link
Contributor

source-amplitude test report (commit bbe4fc166f) - ✅

⏲️ Total pipeline duration: 12mn37s

Step Result
Connector package install
Build source-amplitude docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-amplitude/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amplitude test

@@ -99,8 +100,16 @@ def _date_time_to_rfc3339(self, record: MutableMapping[str, Any]) -> MutableMapp
record[item] = pendulum.parse(record[item]).to_rfc3339_string()
return record

def get_most_recent_cursor(self, stream_state: Mapping[str, Any] = None) -> datetime.datetime:
cursor_date = (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add comment how cursor look like for different conditions

@roman-yermilov-gl roman-yermilov-gl merged commit 2367d52 into master Sep 18, 2023
32 checks passed
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-amplitude-fix-most-recent-cursor-value branch September 18, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amplitude
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Amplitude: Use start_time instead of cursor in the case of more recent
3 participants