Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci,gradle: replace airbyte-docker with airbyte-ci #30743

Merged
merged 12 commits into from
Oct 4, 2023

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Sep 25, 2023

Note that this PR is based on #30607 ; however for what's of interest in this commit those changes are for the most part unrelated.

This PR replaces the airbyte-docker plugin on connectors with a task that execs airbyte-ci to build and load the docker images for each connector. For this purpose I had to mess with airbyte-ci a bit and add a couple of flags which make this tolerably fast.

This is very largely inspired by #28817

Fixes #30403

@postamar postamar requested review from a team as code owners September 25, 2023 21:04
@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2023 3:18pm

@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@airbyte-oss-build-runner
Copy link
Collaborator

destination-elasticsearch-strict-encrypt test report (commit 87f6a85d38) - ❌

⏲️ Total pipeline duration: 07mn49s

Step Result
Build connector tar
Build destination-elasticsearch-strict-encrypt docker image for platform linux/x86_64
Java Connector Unit Tests
Java Connector Integration Tests
Validate metadata for destination-elasticsearch-strict-encrypt
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-elasticsearch-strict-encrypt test

@airbyte-oss-build-runner
Copy link
Collaborator

source-kafka test report (commit 87f6a85d38) - ❌

⏲️ Total pipeline duration: 05mn36s

Step Result
Build connector tar
Build source-kafka docker image for platform linux/x86_64
Java Connector Unit Tests
Java Connector Integration Tests
Acceptance tests
Validate metadata for source-kafka
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-kafka test

@postamar
Copy link
Contributor Author

I really ran this branch through its paces today on my laptop and found a couple more bugs. This led me to rewrite the BuildConnectorImage* classes to allow more granular platform targeting. I kind of like the end result, in principle at least.

Copy link
Contributor

@bnchrch bnchrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me!

Just a few minor comments.

Also im running tests for

-name=destination-azure-blob-storage --name=source-postgres --name=destination-clickhouse

https://github.com/airbytehq/airbyte/actions/runs/6399510931

Lets wait to see these pass (or fail with a valid excuse) before we merge

@airbyte-oss-build-runner
Copy link
Collaborator

destination-bigquery-denormalized test report (commit 13479b1947) - ❌

⏲️ Total pipeline duration: 01mn09s

Step Result
Validate metadata for destination-bigquery-denormalized
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery-denormalized test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-tidb test report (commit 13479b1947) - ❌

⏲️ Total pipeline duration: 03mn00s

Step Result
Build connector tar
Build destination-tidb docker image for platform(s) linux/x86_64
Validate metadata for destination-tidb
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-tidb test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-duckdb test report (commit 13479b1947) - ✅

⏲️ Total pipeline duration: 03mn06s

Step Result
Connector package install
Build destination-duckdb docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for destination-duckdb
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-duckdb test

@airbyte-oss-build-runner
Copy link
Collaborator

source-file-secure test report (commit 13479b1947) - ❌

⏲️ Total pipeline duration: 04mn14s

Step Result
Connector package install
Build source-file-secure docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-file-secure
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file-secure test

@postamar
Copy link
Contributor Author

postamar commented Oct 4, 2023

Thanks again for taking another look. Everything seems as green as can be including that workflow you ran. In addition to what you reviewed I pushed some very trivial changes like requiring python 3.10 across the board instead of 3.9, and setting an env var when calling airbyte-ci to make the logging output prettier. I'll wait for the CI to finish before merging.

@airbyte-oss-build-runner
Copy link
Collaborator

destination-bigquery-denormalized test report (commit a42fe26401) - ❌

⏲️ Total pipeline duration: 01mn08s

Step Result
Validate metadata for destination-bigquery-denormalized
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery-denormalized test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-duckdb test report (commit a42fe26401) - ✅

⏲️ Total pipeline duration: 03mn48s

Step Result
Connector package install
Build destination-duckdb docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for destination-duckdb
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-duckdb test

@airbyte-oss-build-runner
Copy link
Collaborator

source-file-secure test report (commit a42fe26401) - ❌

⏲️ Total pipeline duration: 04mn22s

Step Result
Connector package install
Build source-file-secure docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-file-secure
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file-secure test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-bigquery-denormalized test report (commit b16da1b134) - ❌

⏲️ Total pipeline duration: 41.75s

Step Result
Validate metadata for destination-bigquery-denormalized
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery-denormalized test

@airbyte-oss-build-runner
Copy link
Collaborator

source-file-secure test report (commit b16da1b134) - ❌

⏲️ Total pipeline duration: 02mn06s

Step Result
Connector package install
Build source-file-secure docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-file-secure
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file-secure test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-duckdb test report (commit b16da1b134) - ✅

⏲️ Total pipeline duration: 02mn32s

Step Result
Connector package install
Build destination-duckdb docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for destination-duckdb
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-duckdb test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-exasol test report (commit b16da1b134) - ❌

⏲️ Total pipeline duration: 07mn13s

Step Result
Build connector tar
Build destination-exasol docker image for platform(s) linux/x86_64
Java Connector Unit Tests
Java Connector Integration Tests
Validate metadata for destination-exasol
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-exasol test

@airbyte-oss-build-runner
Copy link
Collaborator

source-alloydb test report (commit b16da1b134) - ❌

⏲️ Total pipeline duration: 03mn53s

Step Result
Build connector tar
Build source-alloydb docker image for platform(s) linux/x86_64
Java Connector Unit Tests
Java Connector Integration Tests
Acceptance tests
Validate metadata for source-alloydb
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-alloydb test

@postamar
Copy link
Contributor Author

postamar commented Oct 4, 2023

/approve-and-merge reason="cannot run all connector tests for this PR"

@postamar postamar disabled auto-merge October 4, 2023 15:37
@postamar postamar merged commit f8edc18 into master Oct 4, 2023
21 of 98 checks passed
@postamar postamar deleted the postamar/use-airbyte-ci branch October 4, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/octavia-cli CDK Connector Development Kit connectors/destination/azure-blob-storage connectors/destination/bigquery connectors/destination/bigquery-denormalized connectors/destination/cassandra connectors/destination/clickhouse connectors/destination/clickhouse-strict-encrypt connectors/destination/csv connectors/destination/databricks connectors/destination/dev-null connectors/destination/doris connectors/destination/duckdb connectors/destination/dynamodb connectors/destination/e2e-test connectors/destination/elasticsearch connectors/destination/elasticsearch-strict-encryp connectors/destination/exasol connectors/destination/gcs connectors/destination/iceberg connectors/destination/kafka connectors/destination/keen connectors/destination/kinesis connectors/destination/kvdb connectors/destination/local-json connectors/destination/mariadb-columnstore connectors/destination/mongodb connectors/destination/mongodb-strict-encrypt connectors/destination/mqtt connectors/destination/mssql connectors/destination/mssql-strict-encrypt connectors/destination/mysql connectors/destination/mysql-strict-encrypt connectors/destination/oracle connectors/destination/oracle-strict-encrypt connectors/destination/postgres connectors/destination/postgres-strict-encrypt connectors/destination/pubsub connectors/destination/pulsar connectors/destination/r2 connectors/destination/redis connectors/destination/redpanda connectors/destination/redshift connectors/destination/rockset connectors/destination/s3-glue connectors/destination/s3 connectors/destination/scylla connectors/destination/selectdb connectors/destination/snowflake connectors/destination/starburst-galaxy connectors/destination/teradata connectors/destination/tidb connectors/destination/vertica connectors/destination/yugabytedb connectors/source/alloydb connectors/source/alloydb-strict-encrypt connectors/source/azure-blob-storage connectors/source/bigquery connectors/source/clickhouse connectors/source/clickhouse-strict-encrypt connectors/source/cockroachdb connectors/source/cockroachdb-strict-encrypt connectors/source/db2-strict-encrypt connectors/source/db2 connectors/source/dynamodb connectors/source/e2e-test connectors/source/e2e-test-cloud connectors/source/elasticsearch connectors/source/file-secure connectors/source/jdbc connectors/source/kafka connectors/source/mongodb connectors/source/mongodb-strict-encrypt connectors/source/mongodb-v2 connectors/source/mssql connectors/source/mssql-strict-encrypt connectors/source/mysql connectors/source/mysql-strict-encrypt connectors/source/oracle connectors/source/oracle-strict-encrypt connectors/source/postgres connectors/source/postgres-strict-encrypt connectors/source/python-http-tutorial connectors/source/redshift connectors/source/scaffold-java-jdbc connectors/source/sftp connectors/source/snowflake connectors/source/stock-ticker-api-tutorial connectors/source/teradata connectors/source/tidb normalization
Projects
None yet
4 participants